Skip to content

Temporarily remove building mac-catalyst targets to enable pipelines #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2022

Conversation

tmarkovski
Copy link
Contributor

@tmarkovski tmarkovski commented Nov 25, 2022

Due to upstream bug in cc-rs, mac catalyst rust targets are failing to build. This PR removes the building of these targets until fix is in.

@tmarkovski tmarkovski changed the title Temporarily remove building mac-catalyst targets to enable Temporarily remove building mac-catalyst targets to enable pipelines Nov 25, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2022

Codecov Report

Base: 69.77% // Head: 19.88% // Decreases project coverage by -49.88% ⚠️

Coverage data is based on head (e856db5) compared to base (aed88a3).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##               main     #563       +/-   ##
=============================================
- Coverage     69.77%   19.88%   -49.89%     
- Complexity        0       32       +32     
=============================================
  Files             9       87       +78     
  Lines           268    16195    +15927     
  Branches          0     2035     +2035     
=============================================
+ Hits            187     3221     +3034     
- Misses           67    12682    +12615     
- Partials         14      292      +278     
Impacted Files Coverage Δ
go/okapi/native.go 73.86% <100.00%> (+0.92%) ⬆️
dotnet/Library/Okapi/Oberon.cs 100.00% <0.00%> (ø)
...art/lib/proto/okapi/transport/v1/transport.pb.dart 0.00% <0.00%> (ø)
java/src/main/java/trinsic/okapi/keys/v1/Keys.java 14.96% <0.00%> (ø)
...a/src/main/java/trinsic/okapi/OkapiByteBuffer.java 100.00% <0.00%> (ø)
ruby/test/util_test.rb 100.00% <0.00%> (ø)
dotnet/Library/Okapi/DIDCommException.cs 41.17% <0.00%> (ø)
dart/lib/proto/pbmse/v1/pbmse.pbenum.dart 25.00% <0.00%> (ø)
java/src/main/java/trinsic/okapi/ExternError.java 80.00% <0.00%> (ø)
...ython/trinsicokapi/proto/okapi/keys/v1/__init__.py 100.00% <0.00%> (ø)
... and 69 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fundthmcalculus fundthmcalculus merged commit cfbdfcd into main Nov 25, 2022
@fundthmcalculus fundthmcalculus deleted the ™️/fix-mac-build branch November 25, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants