Skip to content

[BUG] RNIPs parameters are not correct in examples #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Dirack opened this issue Jun 15, 2022 · 1 comment · Fixed by #55
Closed

[BUG] RNIPs parameters are not correct in examples #24

Dirack opened this issue Jun 15, 2022 · 1 comment · Fixed by #55
Assignees
@Dirack
Labels
bug Something isn't working enhancement New feature or request
Milestone
Package version 3...

Comments

@Dirack
Copy link
Owner

Dirack commented Jun 15, 2022

🐛 Bug report

Describe the bug

For simple models, RNIPs parameters are not inverted correctly. It occurs because you are not using correct coordinates (Half-Offsets instead of Offsets). So, use a flag to inform the program if you are using half-offset coordinates or offsets and treat it properly.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.
@Dirack Dirack added bug Something isn't working enhancement New feature or request labels Jun 15, 2022
@Dirack Dirack self-assigned this Jun 15, 2022
Dirack added a commit that referenced this issue Dec 24, 2022
@Dirack
Use 'half' flag to use half-offset coordinates #24
522c510 
The 'half' flag informs to program that seismic data cube is in half-offset coordinates instead of offset
@Dirack Dirack added this to the Package version 3.0.0 release milestone Feb 5, 2024
@Dirack
Copy link
Owner Author

Dirack commented Feb 7, 2024

Test the RNIP parameters optimization using plane reflector model and circular reflector model

Dirack added a commit that referenced this issue Feb 25, 2024
@Dirack
[test](parameters): Test vfsa optimization correct RNIP and BETA #24
685831f 
Test if the vfsa is getting the correct values for RNIP and BETA
parameters in a simples plane interfaces velocity model
@Dirack Dirack mentioned this issue Feb 25, 2024
Merged
7 tasks
Dirack added a commit that referenced this issue Feb 25, 2024
@Dirack
Merge pull request #54 from Dirack/feature/issue/24
5f66ba6 
[test](parameters): Test vfsa optimization correct RNIP and BETA #24
@Dirack Dirack mentioned this issue Feb 25, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dirack Dirack

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
Package version 3.0.0 release
Development

Successfully merging a pull request may close this issue.

Develop/2.2.2 Dirack/vfsa
1 participant
@Dirack