Added stopword list for German (de_DE) as pattern and PHP #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi thanks for your contribution, I will check out your changes today and if all is fine I'll do the merge. |
Donatello-za
added a commit
that referenced
this pull request
Jun 23, 2020
Merged pull request #20: Added stopword list for German (de_DE) as pattern and PHP.
|
Thanks again, your changes looks good, unit tests succeeded and all the files are in the correct format. Thanks for cleaning up the README also! I have released version v1.0.15 with your changes. PS: Your scraper library looks interesting, I've starred it and will be watching it. :) |
|
Hey @Donatello-za awesome, thank you! Great you like it, let me know if I can help otherwise :) Cheers, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @Donatello-za
I've added your rake lib to my project PHPScraper to extract keywords. I noticed it doesn't have a German stop list and decided to add one in. I also used the chance to tidy up the README a bit. Let me know what you think.
Cheers,
Peter