Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to apply labels to submitted pods #48

Merged
merged 2 commits into from
Feb 14, 2019
Merged

Option to apply labels to submitted pods #48

merged 2 commits into from
Feb 14, 2019

Conversation

dleehr
Copy link
Member

@dleehr dleehr commented Feb 14, 2019

Add labels to submitted Pods using --pod-labels <yaml_file>

  • Adds CalrissianRuntimeContext subclass with a pod_labels attribute
  • CalrissianCommandLineJob reads the YAML (or JSON) file of labels and provides a dictionary to KubernetesPodBuilder
  • KubernetesPodBuilder takes a dictionary of labels in its constructor, to provide as the pod's metadata.labels (ensuring conversion to string)

Fixes #38

@dleehr
Add labels to submitted Pods using --pod-labels <yaml_file>
8cd3f5d 
- Adds CalrissianRuntimeContext subclass with a pod_labels attribute
- CalrissianCommandLineJob reads the YAML (or JSON) file of labels and provides a dictionary to KubernetesPodBuilder
- KubernetesPodBuilder takes a dictionary of labels in its constructor, to provide as the pod's metadata.labels

Fixes #38
@dleehr
Ensure pod labels are strings
d7f8597
@dleehr dleehr requested a review from johnbradley February 14, 2019 20:28
@dleehr
Copy link
Member Author

dleehr commented Feb 14, 2019

In action:

pod-labels

johnbradley
johnbradley approved these changes Feb 14, 2019
View reviewed changes
Copy link
Contributor

@johnbradley johnbradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dleehr dleehr merged commit b235794 into master Feb 14, 2019
@dleehr dleehr deleted the 38-label-submitted-pods branch February 14, 2019 21:40
@johnbradley johnbradley mentioned this pull request Mar 7, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnbradley johnbradley johnbradley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dleehr @johnbradley