Skip to content

Section 508 and NCI Style #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
27 tasks done
nutjob4life opened this issue Sep 15, 2020 · 4 comments
Closed
27 tasks done

Section 508 and NCI Style #69

nutjob4life opened this issue Sep 15, 2020 · 4 comments
Assignees
@nutjob4life
Labels
🧙‍♀️enhancement New feature or request
Milestone
5.1.0

Comments

@nutjob4life
Copy link
Member

nutjob4life commented Sep 15, 2020 •
edited
Loading

🤔 Tell Us About the Feature

The following issue is transliterated from an email from Kara Smigel, Message-ID <MN2PR09MB4971948DE2B925AB5A04194990200@MN2PR09MB4971.namprd09.prod.outlook.com>.

🎇 What Solution You'd Like

In this email, Kara wrote:

The Powerpoint attached runs down the 508 and NCI style guidelines that need to be followed on the EDRN website . We tried to give a full technical explanation plus links to resources and guidelines to help make the changes. I’ve also attached two files of the EDRN banner that is the “legal” one to use on the website: the .svg format, used for responsive websites, as well as a .png version suitable for desktop.

〽️ Alternative Ideas

We can ignore the ideas that apply to development only (things like the development warning banner) and things that we can correct via content management interaction post-deployment.

🗺 Context

The email had these attached attachments:

A powerpoint:

edrn-dev-issues-solutions-draft.pptx

An image:

EDRN_54px-Logo-COLOR

A SVG was promised but not included.

☑️ Tasks

  • Background color
  • Logo
  • DMCC Site and Log in placement
  • Search only in current section placement
  • DMCC site tooltip
  • "Home" color contrast
  • Down arrow on "About EDRN"
  • Menu bar changes during navigation (page 6)
  • Color contrast on gradient backgrounds
  • Color contrast on green tabs (Biomarker "Basics" tab, e.g.)
  • Color contrast on 〉 in breadcrumbs
  • Color contrast on hyperlink underline color
  • Table headers missing on informatics tools
  • Table padding missing
  • No rounded corners
  • Form elements must have labels (page 12)
  • Body font size too small (page 16)
  • Header progression (h1, h2, h3, …, page 18)
  • Remove underlining from "Biomarker Statistics"
  • Mark visited links (page 21)
  • Remove "mailto" from email addresses
  • Indicate attached file types
  • Offsite link icon (page 26)
  • Footer links (pages 31–32)
  • High contrast home page redesign (page 33)
  • Typos (page 34)
  • In-development changes (page 35)
@nutjob4life nutjob4life added the 🧙‍♀️enhancement New feature or request label Sep 15, 2020
@nutjob4life nutjob4life added this to the 5.0.3 milestone Sep 15, 2020
@nutjob4life nutjob4life self-assigned this Sep 15, 2020
@nutjob4life
Copy link
Member Author

In Message-ID <DM8PR09MB7046AEEC5F959681D45C4C2BF7200@DM8PR09MB7046.namprd09.prod.outlook.com>,
Wayne Randall followed up with two additional attachments.

NCI-Digital-Style-Guide.pdf
NCI-Branding-and-Logo-Use-Guide_5.pdf

@nutjob4life
Copy link
Member Author

Ignoring "Color contrast on gradient backgrounds" as it refers to this banner:

Screen Shot 2020-09-17 at 11 40 57 AM

This only applies to in-development and demo sites—who cares about those! 😇

nutjob4life added a commit that referenced this issue Sep 23, 2020
@nutjob4life
WIP #69 — add "title" attribute to "DMCC Site" hyperlink
c4ce2f4
nutjob4life added a commit that referenced this issue Sep 23, 2020
@nutjob4life
WIP #69 - Kara's "high contrast" changes
4750a84
nutjob4life added a commit that referenced this issue Sep 23, 2020
@nutjob4life
WIP #69 — Kara wants the down-arrow on About EDRN and while we're her…
95ad55f 
…e let's make sure the "Archive" stays off the nav bar
@nutjob4life nutjob4life mentioned this issue Sep 28, 2020
Closed
@nutjob4life nutjob4life modified the milestones: 5.0.3, 5.1.0 Oct 8, 2020
@nutjob4life
Copy link
Member Author

As for "Form elements must have labels (page 12)", nothing we can do; I've reported the issue to the faceted navigation developers. For now we can take solace that the <legend> tells what the control is for by context even if it doesn't have an explicit <label>.

nutjob4life added a commit that referenced this issue Oct 18, 2020
@nutjob4life
More #69 WIP
8fa600a 
- Adjust hyperlink underlines so they're not *as* awful
- Add table headers to informatics tools
- Add table padding
- Remove rounded corners
- Fix body font sizes on main pages, biomarker templates
- Fix header progression
- Remove underlining from David's stat graphs
- Mark visited links with differing color
- Remove displayed "mailto:" from addresses
- Add actionable "mailto:" hyperlinks to email addresses
- Massive footer cleanup
nutjob4life added a commit that referenced this issue Oct 19, 2020
@nutjob4life
More WIP #69
6c949aa
nutjob4life added a commit that referenced this issue Oct 19, 2020
@nutjob4life
WIP #69 — with rearranged items we need to adjust ingest paths for ol…
053c8ea 
…d `resources/` things
@nutjob4life nutjob4life mentioned this issue Oct 19, 2020
Closed
This was referenced Feb 25, 2021
Closed
Closed
@nutjob4life
Copy link
Member Author

These items are moved to their own issues:

There are hereby marked as complete here, by the by.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nutjob4life nutjob4life

Labels
🧙‍♀️enhancement New feature or request
Projects
None yet
Milestone
5.1.0
Development

No branches or pull requests
1 participant
@nutjob4life