Skip to content

ctsm5.3.041: Various cleanup efforts from the cesm3_0_beta04 tags for testing and usability #2950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 28 commits into
base: master
Choose a base branch
from

Conversation

ekluzek
Copy link
Collaborator

@ekluzek ekluzek commented Feb 4, 2025

Description of changes

Various updates for testing and other problems identified in the cesm3_0_beta04 tag. So fixes and cleanup for usability.

Specific notes

Contributors other than yourself, if any: @slevis-lmwg

CTSM Issues Fixed (include github issue #):
#2868
#2791
#2768
#2780

Are answers expected to change (and if so in what way)? No

Any User Interface Changes (namelist or namelist defaults changes)? Yes

Does this create a need to change or add documentation? Did you do so? No

Testing performed, if any: Will Do regular

PR's Involved:

#2840
#2835
#2834

slevis-lmwg and others added 25 commits October 16, 2024 15:33
…efile

slevis resolved conflicts:
bld/unit_testers/build-namelist_test.pl
Bring back clm5-cam6 init_interp_attributes for ne0CONUS grid
…file

ne3np4 to namelist_defaults_ctsm.xml and Makefile for PTS mode and add ability for warm starts in PTS mode
@ekluzek ekluzek added enhancement new capability or improved behavior of existing capability priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations code health improving internal code structure to make easier to maintain (sustainability) bfb bit-for-bit usability Improve or clarify user-facing options labels Feb 4, 2025
@ekluzek ekluzek added test: python Pass clm_pymods test suite plus Python sys/unit tests before merging test: aux_clm Pass aux_clm suite before merging labels Feb 4, 2025
@ekluzek ekluzek added this to the CESM3 Answer changing freeze milestone Feb 4, 2025
@ekluzek ekluzek self-assigned this Mar 4, 2025
@ekluzek ekluzek moved this from Todo to In Progress in LMWG: Sprint Planning Board Mar 4, 2025
@samsrabin
Copy link
Collaborator

@ekluzek What's the status of this? Is any of it ready to come in / can any of it be split out into different PRs?

@ekluzek ekluzek changed the title [WIP]: Various cleanup efforts from the cesm3_0_beta04 tags for testing and usability Various cleanup efforts from the cesm3_0_beta04 tags for testing and usability Apr 16, 2025
@ekluzek ekluzek moved this to In progress - master/b4b-dev in CTSM: Upcoming tags Apr 16, 2025
@ekluzek ekluzek changed the title Various cleanup efforts from the cesm3_0_beta04 tags for testing and usability ctsm5.3.041: Various cleanup efforts from the cesm3_0_beta04 tags for testing and usability Apr 16, 2025
@ekluzek
Copy link
Collaborator Author

ekluzek commented Apr 16, 2025

@samsrabin this is my next tag to bring in. We created this branch a long time ago because we thought that the PR's on it would flood b4b-dev too much. But, it turned out the work on it was spread out long enough that that wouldn't have been an issue. At least for this second go around. With b4b-dev we have a clock that ensures changes come in regularly, but we didn't have a process to that here. So it didn't happen. I think that means that in the future we should either slide these things as individual tags to master, or bring them to b4b-dev. Or think about the process that should be in place for a temporary branch like this....

It was brought into this branch as separate PR's similarly to b4b-dev and the first go around with this work. So you can view the contributions singly with those PR's already.

With your ask -- I thought about rebasing the PR's that went into this onto b4b-dev. But at this point I think that would only serve to create more work and slow the work down. So I won't do that now, but this can serve as something to think about as lessons for the future. I'll add this to the Thursday discussion.

@ekluzek
Copy link
Collaborator Author

ekluzek commented Apr 16, 2025

These tests fail on setup because they are using fire-emis with SP cases. So I'll reconfigure these tests to make sure the testmods used include nofireemis.

ERP_D_Ld3_PS.f09_g17.I2000Clm50Sp.derecho_intel.clm-prescribed (SETUP)
ERP_D_Ld5.f10_f10_mg37.I2000Clm60Sp.derecho_intel.clm-decStart (SETUP)
ERP_D_Ld5.f10_f10_mg37.IHistClm45Sp.derecho_intel.clm-decStart (SETUP)
ERP_D_Ld5.f10_f10_mg37.IHistClm60Sp.derecho_intel.clm-default (SETUP)
ERP_D_Ld5.ne30pg3_t232.IHistClm60Sp.derecho_intel.clm-default (SETUP)
ERP_P64x2_D.f10_f10_mg37.I2000Clm50SpRtmFl.derecho_intel.clm-default (SETUP)
ERP_P64x2_D_Ld5.f10_f10_mg37.I2000Clm45Sp.derecho_intel.clm-default (SETUP)
ERP_P64x2_D_Ld5.f10_f10_mg37.I2000Clm50Sp.derecho_gnu.clm-default (SETUP)
ERP_P64x2_D_Ld5.f10_f10_mg37.I2000Ctsm50NwpSpGswp.derecho_intel.clm-default (SETUP)
ERS_D_Ld10.f10_f10_mg37.IHistClm50Sp.derecho_intel.clm-collapse_pfts_78_to_16_decStart_f10 (SETUP)
NCK_Ld1.f10_f10_mg37.I2000Clm50Sp.derecho_intel.clm-default (SETUP)
SMS_C2_D_Lh12.f10_f10_mg37.I2000Clm50Sp.derecho_intel.clm-pauseResume (SETUP)
SMS_D_Ld1_Mmpi-serial.ne3_ne3_mg37.I2000Clm50SpRs.derecho_gnu.clm-ptsRLA (SETUP)
SMS_D_Ld1_Mmpi-serial.ne3_ne3_mg37.I2000Clm50SpRs.derecho_gnu.clm-ptsROA (SETUP)
SMS_D_Ld1_Mmpi-serial.ne3_ne3_mg37.I2000Clm50SpRs.derecho_intel.clm-ptsRLA (SETUP)
SMS_D_Ld1_PS.f09_g17.I1850Clm50Sp.derecho_intel.clm-default (SETUP)
SMS_D_Ln9_P128x3.f19_g17.IHistClm50Sp.derecho_intel.clm-waccmx_offline (SETUP)
SMS_Ld10_D_Mmpi-serial.CLM_USRDAT.I1PtClm60SpRs.derecho_intel.clm-default--clm-NEON-TOOL (SETUP)
SMS_Ld1_PS.nldas2_rnldas2_mnldas2.I2000Ctsm50NwpSpNldas.derecho_gnu.clm-default (SETUP)
SMS_Ld1_PS.nldas2_rnldas2_mnldas2.I2000Ctsm50NwpSpNldasRs.derecho_gnu.clm-default (SETUP)
SMS_P384x2_D_Ld5.f19_g17.I2000Clm50Sp.derecho_intel.clm-default (SETUP)

ekluzek and others added 2 commits April 16, 2025 18:20
Update ctsm_pylib to 3.13.2

 Conflicts:
	cime_config/testdefs/testlist_clm.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bfb bit-for-bit code health improving internal code structure to make easier to maintain (sustainability) enhancement new capability or improved behavior of existing capability priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations test: aux_clm Pass aux_clm suite before merging test: python Pass clm_pymods test suite plus Python sys/unit tests before merging usability Improve or clarify user-facing options
Projects
Status: In progress - master
Status: In Progress
Development

Successfully merging this pull request may close these issues.

4 participants