Fix wrong index when writing to array #5
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug: At one point the index when writing to the array rlist
was wrong. The original QUADPACK code looks like:
As arrays start with index 0 in C, the access of rlist2 should look like:
This change also fixes undeterministic behavior of the function dquadi due to a
use of uninitialized value. With this fix the memory access seems fine and
LLVM's MemorySanitizer does no longer complain.