Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dmirano/3721 optimize cypress tests #3758

Merged
merged 9 commits into from
Feb 8, 2022

Conversation

mirano-darren
Copy link
Contributor

Resolves #3721 and #3732

Description-
These changes modify the proposed budget cypress tests to run faster

This pull request changes...

  • proposed budget stuff in /cypress/
  • added some test variables on the proposed budget page in /web/
  • added a getEAPDTable() to cypress commands that should convert a table to a JSON
    • doesn't work with every table as they are not all identical, I can add more commands for specific tables in the future.

Steps to manually verify this change...

  1. cypress tests pass on github actions, but feel free to try it on your local machine

This pull request is ready to review when...

  • Automated tests are updated (and all tests are passing)
  • The change has been documented
  • Associated OpenAPI documentation has been updated
  • Changelog is updated as appropriate
  • The experience passes a basic manual accessibility audit (keyboard nav, screenreader, text scaling) OR an exemption is documented

This pull request can be merged when…

  • Code has been reviewed by someone other than the original author
  • QA has verified the accessibility and functionality related to the change
  • Design has approved the experience
  • Product has approved the experience

@mirano-darren mirano-darren temporarily deployed to Preview February 7, 2022 20:04 Inactive
@mirano-darren mirano-darren temporarily deployed to Preview February 7, 2022 20:04 Inactive
@mirano-darren mirano-darren temporarily deployed to Preview February 7, 2022 20:04 Inactive
@mirano-darren mirano-darren temporarily deployed to Preview February 7, 2022 21:54 Inactive
@mirano-darren mirano-darren temporarily deployed to Preview February 7, 2022 21:54 Inactive
@mirano-darren mirano-darren temporarily deployed to Preview February 7, 2022 21:54 Inactive
@mirano-darren mirano-darren temporarily deployed to Preview February 7, 2022 21:54 Inactive
@cms-eapd-bot
Copy link

cms-eapd-bot commented Feb 7, 2022

This deploy was cleaned up.

Copy link
Contributor

@thetif thetif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! also great speed up on the cypress run!

@thetif
Copy link
Contributor

thetif commented Feb 8, 2022

Test Name Previous Run Time New Run Time Diff
✓ should have the default values for Proposed Budget (1146738ms) (20970ms) 18.7628 minutes
✓ should display the default values for Proposed Budget in export view (1276435ms) (25087ms) 20.8558 minutes
✓ should have the correct values for Proposed Budget (1146738ms) (111976ms) 17.2460333 minutes
✓ should export the correct values for Proposed Budget Export View (1276435ms) (32827ms) 20.7268 minutes

Total reduction: 1.29319056 hours

@mirano-darren mirano-darren merged commit 6638c83 into main Feb 8, 2022
@mirano-darren mirano-darren deleted the dmirano/3721-optimize-cypress-tests branch February 8, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Testing] Optimize Cypress tests to run faster.
3 participants