-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add sanitizer #3846
add sanitizer #3846
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3846 +/- ##
==========================================
- Coverage 83.34% 83.32% -0.02%
==========================================
Files 313 313
Lines 6393 6398 +5
Branches 1204 1204
==========================================
+ Hits 5328 5331 +3
- Misses 971 973 +2
Partials 94 94
Continue to review full report at Codecov.
|
This deploy was cleaned up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good 👍
"engines": { | ||
"node": "16.13.2" | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just curious, whats the intention with adding this top-level?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Good stuff, Everything looks unphased and booted up as normal.
Quick note: If you get a Mongo error on "docker compose up" you need to update your env_vars
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the deployment issue with Mongo too!
Resolves #3832
Description-
Resolve issues discovered by the snyk plugin in vscode.
This pull request changes...
This pull request also touches…
This pull request was tested in the follow ways…
This pull request is ready to review when...
This pull request can be merged when…