Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dmirano/3778 apd overview components restructure #3896

Merged
merged 23 commits into from
Mar 25, 2022

Conversation

mirano-darren
Copy link
Contributor

Resolves #3778

Description-
apd overview component refactor

This pull request changes...

  • file locations of requested files and affected tests

This pull request was tested in the follow ways…

  • npm test passes in /web/
  • app boots up normally

Steps to manually verify this change...

  1. verify all files were moved to the desired location

This pull request is ready to review when...

  • Automated tests are updated (and all tests are passing)
  • The change has been documented
  • Associated OpenAPI documentation has been updated
  • Changelog is updated as appropriate
  • The experience passes a basic manual accessibility audit (keyboard nav, screenreader, text scaling) OR an exemption is documented

This pull request can be merged when…

  • Code has been reviewed by someone other than the original author
  • QA has verified the accessibility and functionality related to the change
  • Design has approved the experience
  • Product has approved the experience

@mirano-darren mirano-darren temporarily deployed to Preview March 25, 2022 14:59 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2022

Codecov Report

Merging #3896 (38fad08) into main (a1981a6) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3896   +/-   ##
=======================================
  Coverage   83.31%   83.31%           
=======================================
  Files         313      313           
  Lines        6400     6400           
  Branches     1205     1205           
=======================================
  Hits         5332     5332           
  Misses        974      974           
  Partials       94       94           
Impacted Files Coverage Δ
web/src/containers/ApdApplication.js 91.17% <ø> (ø)
web/src/pages/apd/ApdPageRoutes.js 100.00% <ø> (ø)
web/src/pages/apd/ApdReadOnly.js 14.70% <ø> (ø)
web/src/pages/routes.js 100.00% <ø> (ø)
web/src/pages/apd/apd-overview/ApdOverview.js 48.64% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1981a6...38fad08. Read the comment docs.

@cms-eapd-bot
Copy link

cms-eapd-bot commented Mar 25, 2022

This deploy was cleaned up.

@mirano-darren mirano-darren temporarily deployed to Preview March 25, 2022 19:01 Inactive
@mirano-darren mirano-darren merged commit 253870f into main Mar 25, 2022
@mirano-darren mirano-darren deleted the dmirano/3778-apd-overview-components-restructure branch March 25, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] move apd overview components into an apd-overview folder
4 participants