Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dmirano/3786 activities restructure #3958

Merged
merged 43 commits into from
Apr 11, 2022

Conversation

mirano-darren
Copy link
Contributor

Resolves #3786

Description-
activities refactor

This pull request changes...

  • file locations of requested filed and affected tests

This pull request was tested in the follow ways…

  • npm test in /web/ passes
  • app boots up normally

Steps to manually verify this change...

  1. verify all requested files were moved to the right location

This pull request is ready to review when...

  • Automated tests are updated (and all tests are passing)
  • The change has been documented
  • Associated OpenAPI documentation has been updated
  • Changelog is updated as appropriate
  • The experience passes a basic manual accessibility audit (keyboard nav, screenreader, text scaling) OR an exemption is documented

This pull request can be merged when…

  • Code has been reviewed by someone other than the original author
  • QA has verified the accessibility and functionality related to the change
  • Design has approved the experience
  • Product has approved the experience

@mirano-darren mirano-darren temporarily deployed to Preview April 8, 2022 13:24 Inactive
@codecov-commenter
Copy link

Codecov Report

Merging #3958 (1ee37ce) into main (2c77f15) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3958   +/-   ##
=======================================
  Coverage   83.53%   83.53%           
=======================================
  Files         313      313           
  Lines        6400     6400           
  Branches     1210     1210           
=======================================
  Hits         5346     5346           
  Misses        960      960           
  Partials       94       94           
Impacted Files Coverage Δ
web/src/pages/apd/activities/ActivityRoutes.js 100.00% <ø> (ø)
web/src/containers/activity/EntryPage.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c77f15...1ee37ce. Read the comment docs.

@cms-eapd-bot
Copy link

cms-eapd-bot commented Apr 8, 2022

This deploy was cleaned up.

@mirano-darren mirano-darren merged commit 4701eb0 into main Apr 11, 2022
@mirano-darren mirano-darren deleted the dmirano/3786-activities-restructure branch April 11, 2022 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] move activities components into an activitvies folder
5 participants