Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dmirano/3793 cost allocation restructure #3976

Merged
merged 71 commits into from
Apr 14, 2022
Merged

Dmirano/3793 cost allocation restructure #3976

merged 71 commits into from
Apr 14, 2022

Conversation

mirano-darren
Copy link
Contributor

Resolves #3793

Description-
cost allocation refactor

This pull request changes...

  • file locations of requested filed and affected tests

This pull request was tested in the follow ways…

  • npm test in /web/ passes
  • app boots up normally

Steps to manually verify this change...

  1. verify all requested files were moved to the right location

This pull request is ready to review when...

  • Automated tests are updated (and all tests are passing)
  • The change has been documented
  • Associated OpenAPI documentation has been updated
  • Changelog is updated as appropriate
  • The experience passes a basic manual accessibility audit (keyboard nav, screenreader, text scaling) OR an exemption is documented

This pull request can be merged when…

  • Code has been reviewed by someone other than the original author
  • QA has verified the accessibility and functionality related to the change
  • Design has approved the experience
  • Product has approved the experience

@mirano-darren
layout restructure
8ad33db
@mirano-darren
updated tests
15203a5
@mirano-darren
Merge branch 'main' of github.com:CMSgov/eAPD into dmirano/3771-layou…
919ae46 
…t-restructure
@mirano-darren
dashboard refactor
d5d03ea
@mirano-darren
update tests
f64001d
@mirano-darren
added login refactor
88b5e1c
@mirano-darren
updated tests
c368ece
@mirano-darren
added admin refactor
430cc7d
@mirano-darren
updated tests
b083356
@mirano-darren
route refactor
9f9faa6
@mirano-darren
route refactor to /pages/
8670f0c
@mirano-darren
updated tests (not finishes yet)
1a0ccf1
@mirano-darren
apd components refactor
e15bdb9
@mirano-darren
updated tests (route still causing issues)
5045cab
@mirano-darren
updated tests
c8223d0
@mirano-darren
update tests, all pass now
41b1baf
@mirano-darren
Merge remote-tracking branch 'origin/dmirano/3772-pages-folder' into …
02d59b7 
…dmirano/3776-apd-component-restructure
@mirano-darren
Merge branch 'main' of github.com:CMSgov/eAPD into dmirano/3776-apd-c…
c25bdb8 
…omponent-restructure

fixed merge conflict in Wrapper.js
@mirano-darren
fixed merge conflicts
e175909
@mirano-darren
relocated apd overview components
7bd59f1
@mirano-darren
updated tests and renamed to ApdOverview
556b022
@mirano-darren
key state refactor
0bfb0ee
@mirano-darren
updated tests
42428bf
@mirano-darren
Merge branch 'main' of github.com:CMSgov/eAPD into dmirano/3779-key-s…
bda4903 
…tate-restructure
@mirano-darren
previous activity restructure
b7f5f08
@mirano-darren
updated tests
aaa28f4
@mirano-darren
schedule summary refactor
3e284d5
@mirano-darren
update tests
9c1cef3
@mirano-darren
executive summary restructure
3c1e2af
@mirano-darren
updated tests
91d401c
@mirano-darren
updated tests
625e385
@mirano-darren
once again, updating failing tests
a44ce42
@mirano-darren
did i mention i was updating the failing tests?
f47c236
@mirano-darren
uft - stands for updating failing tests
8146601
@mirano-darren
updateing. failing. tests.
3420531
@mirano-darren
Merge branch 'main' of github.com:CMSgov/eAPD into dmirano/3788-activ…
b02cf39 
…ity-overview-restructure
@mirano-darren
Merge branch 'main' of github.com:CMSgov/eAPD into dmirano/3791-staff…
126fe94 
…-expenses-restructure
@mirano-darren
fixed failing tests
e380689
@mirano-darren
Merge branch 'main' of github.com:CMSgov/eAPD into dmirano/3792-contr…
223d8b5 
…actor-restructure
@mirano-darren
Merge branch 'main' of github.com:CMSgov/eAPD into dmirano/3788-activ…
c8b3627 
…ity-overview-restructure
@mirano-darren
fixed linting issues
a562fc6
@mirano-darren
updating linting issues
9f537f1
@mirano-darren
Merge remote-tracking branch 'origin/dmirano/3788-activity-overview-r…
b0f6229 
…estructure' into dmirano/3791-staff-expenses-restructure
@mirano-darren
fixed linting issues
7e545ce
@mirano-darren
Merge remote-tracking branch 'origin/dmirano/3791-staff-expenses-rest…
407369d 
…ructure' into dmirano/3792-contractor-restructure
@mirano-darren
updated linted inssues
5045915
@mirano-darren
Merge remote-tracking branch 'origin/dmirano/3792-contractor-restruct…
ae64566 
…ure' into dmirano/3793-cost-allocation-restructure
@mirano-darren mirano-darren temporarily deployed to Preview April 13, 2022 17:26 Inactive
@mirano-darren mirano-darren changed the base branch from main to dmirano/3792-contractor-restructure April 13, 2022 17:30
@mirano-darren mirano-darren added the refactor Issues which require varying degrees of code refactoring label Apr 13, 2022
Base automatically changed from dmirano/3792-contractor-restructure to main April 14, 2022 13:04
@mirano-darren mirano-darren temporarily deployed to Preview April 14, 2022 13:06 Inactive
@cms-eapd-bot
Copy link

cms-eapd-bot commented Apr 14, 2022 •
edited
Loading

This deploy was cleaned up.

@mirano-darren mirano-darren merged commit 473005a into main Apr 14, 2022
@mirano-darren mirano-darren deleted the dmirano/3793-cost-allocation-restructure branch April 14, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbolt tbolt tbolt approved these changes

@thetif thetif Awaiting requested review from thetif

@Sun-Mountain Sun-Mountain Awaiting requested review from Sun-Mountain

Assignees
No one assigned
Labels
refactor Issues which require varying degrees of code refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] move cost allocation components into a cost-allocation folder
3 participants
@mirano-darren @cms-eapd-bot @tbolt