Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing var and updating trigger for testing #4070

Merged
merged 2 commits into from
May 23, 2022

Conversation

cthulhuplus
Copy link
Contributor

@cthulhuplus cthulhuplus commented May 23, 2022

Resolves # 4070 #4070

Description

Adds missing var to preview AMI builds

Significant changes or possible side effects

It's a change to CircleCI config file, so potential to impact builds. It is a part of the weekly ami build, so it could impact that as well.

Automated test cases written

None

Steps to manually verify this change

  1. Ran the change as "on push" and it successfully built a new Preview AMI

This pull request is ready to review when

  • Automated tests are updated (and all tests are passing)
  • Pull request has been labeled, if applicable with feature, content, bug, tests, refactor
  • Associated OpenAPI documentation has been updated
  • The experience passes a basic manual accessibility audit (keyboard nav, screenreader, text scaling) OR an exemption is documented

This pull request can be merged when

  • Code has been reviewed by someone other than the original author
  • QA has verified the accessibility and functionality related to the change
  • Design has approved the experience
  • Product has approved the experience

@cthulhuplus cthulhuplus self-assigned this May 23, 2022
@cthulhuplus cthulhuplus added small DevOps Specific Tasks for DevOps labels May 23, 2022
@cthulhuplus cthulhuplus requested review from thetif and tbolt May 23, 2022 16:43
@cthulhuplus cthulhuplus marked this pull request as ready for review May 23, 2022 16:46
@cms-eapd-bot
Copy link

cms-eapd-bot commented May 23, 2022

This deploy was cleaned up.

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2022

Codecov Report

Merging #4070 (d689086) into main (7d10733) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4070   +/-   ##
=======================================
  Coverage   85.36%   85.36%           
=======================================
  Files         321      321           
  Lines        6483     6483           
  Branches     1250     1250           
=======================================
  Hits         5534     5534           
  Misses        881      881           
  Partials       68       68           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d10733...d689086. Read the comment docs.

@@ -41,7 +41,7 @@ workflows:

# Workflow to build new AMIs based on the latest gold images weekly
weekly aws ami builds:
triggers:
triggers:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@cthulhuplus cthulhuplus merged commit 09a841d into main May 23, 2022
@cthulhuplus cthulhuplus deleted the bbrooks/fixing-preview-ami-20220523 branch May 23, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DevOps Specific Tasks for DevOps small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants