Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tforkner/4045 storybook updates #4112

Merged
merged 82 commits into from
Jun 17, 2022
Merged

Tforkner/4045 storybook updates #4112

merged 82 commits into from
Jun 17, 2022

Conversation

thetif
Copy link
Contributor

@thetif thetif commented Jun 8, 2022

Resolves #4045

Description

  • Updated storybook configs
  • Added some new stories
  • Added scripts to utilize hygen templates
  • Created hygen scripts for adding a story and adding a component

This pull request can be merged when

  • Code has been reviewed by someone other than the original author
  • QA has verified the accessibility and functionality related to the change
  • Design has approved the experience
  • Product has approved the experience

@thetif thetif marked this pull request as ready for review June 8, 2022 21:42
@thetif thetif added the feature PR label for release log label Jun 9, 2022
@thetif thetif requested a review from Sun-Mountain June 9, 2022 21:52
Copy link
Contributor

@tbolt tbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, great updates


const Template = args => <<%= componentName %> {...args} />;

export const DefaultStory = Template.bind({});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have this template in both /components/new and /stories/new ?

}
};

const Template = args => <DeleteModal {...args} />;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good way to see everywhere the Delete modal is used 😄

@thetif thetif merged commit 03d6d34 into main Jun 17, 2022
@thetif thetif deleted the tforkner/4045-storybook-updates branch June 17, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature PR label for release log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Maintenance] Storybook
5 participants