Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tforkner/4060 metrics key #4126

Merged
merged 13 commits into from
Jun 10, 2022
Merged

Tforkner/4060 metrics key #4126

merged 13 commits into from
Jun 10, 2022

Conversation

thetif
Copy link
Contributor

@thetif thetif commented Jun 9, 2022

Resolves #4060

Description

Updated apd loader to assign keys to metrics.

Steps to manually verify this change

  1. open an existing APD
  2. look at the reducer in the browser and verify that outcomes looks the same as before and metrics now has keys

This pull request is ready to review when

  • Automated tests are updated (and all tests are passing)
  • Pull request has been labeled, if applicable with feature, content, bug, tests, refactor
  • Associated OpenAPI documentation has been updated
  • The experience passes a basic manual accessibility audit (keyboard nav, screenreader, text scaling) OR an exemption is documented

This pull request can be merged when

  • Code has been reviewed by someone other than the original author
  • QA has verified the accessibility and functionality related to the change
  • Design has approved the experience
  • Product has approved the experience

@thetif thetif requested a review from tbolt June 9, 2022 17:30
@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2022

Codecov Report

Merging #4126 (fb82c95) into main (1e23385) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #4126   +/-   ##
=======================================
  Coverage   87.63%   87.63%           
=======================================
  Files         215      215           
  Lines        4924     4925    +1     
  Branches     1258     1259    +1     
=======================================
+ Hits         4315     4316    +1     
  Misses        556      556           
  Partials       53       53           
Impacted Files Coverage Δ
...rc/pages/admin/fed-admin/DelegateStateAdminForm.js 65.90% <100.00%> (ø)
...s/oms/OutcomesAndMetrics/OutcomeAndMetricReview.js 90.00% <100.00%> (ø)
web/src/redux/reducers/apd.js 96.87% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e23385...fb82c95. Read the comment docs.

Copy link
Contributor

@tbolt tbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. no more errors in the console about the keys

@thetif thetif changed the title updated apd loader to assign keys to metrics TForkner/add keys to metrics Jun 9, 2022
@thetif thetif changed the title TForkner/add keys to metrics Tforkner/4060 metrics key Jun 9, 2022
@cms-eapd-bot
Copy link

cms-eapd-bot commented Jun 10, 2022

This deploy was cleaned up.

Copy link
Contributor

@mirano-darren mirano-darren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error doesn't appear anymore!

@thetif thetif merged commit a7f3be3 into main Jun 10, 2022
@thetif thetif deleted the tforkner/4060-metrics-key branch June 10, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Maintenance] Outcome and Metrics: Metric key isn't being stored on save.
5 participants