-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tforkner/4060 metrics key #4126
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4126 +/- ##
=======================================
Coverage 87.63% 87.63%
=======================================
Files 215 215
Lines 4924 4925 +1
Branches 1258 1259 +1
=======================================
+ Hits 4315 4316 +1
Misses 556 556
Partials 53 53
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. no more errors in the console about the keys
This deploy was cleaned up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
error doesn't appear anymore!
Resolves #4060
Description
Updated apd loader to assign keys to metrics.
Steps to manually verify this change
This pull request is ready to review when
This pull request can be merged when