-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tforkner/4030 subform cancel #4132
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4132 +/- ##
=======================================
Coverage 87.65% 87.65%
=======================================
Files 215 215
Lines 4932 4932
Branches 1259 1259
=======================================
Hits 4323 4323
Misses 556 556
Partials 53 53 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good and it resolved the issue in the instances I tested
web/src/pages/apd/activities/contractor-costs/ContractorResource/ContractorResourceForm.test.js
Outdated
Show resolved
Hide resolved
This deploy was cleaned up. |
Well done! Tested locally since preview builds were running into an issue when I checked it out. (APDs weren't loading)
Checked on all these subforms: |
…m/CMSgov/eAPD into tforkner/4030-metrics-saved-error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested against all the subforms as listed. Works as advertised!
Resolves #4030
Description
There was an issue where updates were being saved in metrics even when the user clicked cancel. I have updated metrics and the other subforms, to not save anything that was updated if the user clicks cancel.
Automated test cases written
added a cypress test to add info to a metric and then click cancel
Steps to manually verify this change
Please test by trying difference cases of canceling for all subforms:
Key State Personnel
Outcomes and Metrics
Milestones
State Staff
State Expenses
Private Contractor Costs
This pull request is ready to review when
This pull request can be merged when