Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving CloudWatch logging to User-Data #4148

Merged
merged 2 commits into from
Jun 17, 2022

Conversation

cthulhuplus
Copy link
Contributor

Resolves # 4020

Description

Moving CloudWatch back to user-data. If put into Packer, we'd need a separate Staging AMI since environment settings would be applied at AMI creation.

Signifcant changes or possible side effects

Automated test cases written

Steps to manually verify this change

This pull request is ready to review when

  • Automated tests are updated (and all tests are passing)
  • Pull request has been labeled, if applicable with feature, content, bug, tests, refactor
  • Associated OpenAPI documentation has been updated
  • The experience passes a basic manual accessibility audit (keyboard nav, screenreader, text scaling) OR an exemption is documented

This pull request can be merged when

  • Code has been reviewed by someone other than the original author
  • QA has verified the accessibility and functionality related to the change
  • Design has approved the experience
  • Product has approved the experience

@cthulhuplus cthulhuplus requested a review from thetif June 15, 2022 13:51
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2022

Codecov Report

Merging #4148 (a9ca584) into main (4baa84d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4148   +/-   ##
=======================================
  Coverage   87.63%   87.63%           
=======================================
  Files         215      215           
  Lines        4925     4925           
  Branches     1259     1259           
=======================================
  Hits         4316     4316           
  Misses        556      556           
  Partials       53       53           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4baa84d...a9ca584. Read the comment docs.

@cms-eapd-bot
Copy link

cms-eapd-bot commented Jun 15, 2022

This deploy was cleaned up.

@cthulhuplus cthulhuplus requested a review from tbolt June 15, 2022 17:02
@cthulhuplus cthulhuplus merged commit 02c0771 into main Jun 17, 2022
@cthulhuplus cthulhuplus deleted the bbrooks/4020-Move-Logging-to-User-Data branch June 17, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants