Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sev1] NumberField Bug #4165

Merged
merged 9 commits into from
Jun 29, 2022
Merged

[Sev1] NumberField Bug #4165

merged 9 commits into from
Jun 29, 2022

Conversation

tbolt
Copy link
Contributor

@tbolt tbolt commented Jun 27, 2022

Resolves #4161

Description

Allows up to 1/100th of a percent to be input in FTE fields by allowing inputs 0.0 and 0.00. Beyond that the previous behavior will occur where 0.000 will immediately convert to 0

Signifcant changes or possible side effects

  • This is a change to NumberField so it's possible there is an impact to another part of the app.

Automated test cases written

  • Added tests to handle the new allowed cases.

Steps to manually verify this change

  1. Navigate to an FTE field
  2. Enter a decimal with a leading zero such as .01
  3. Verify it enters successfully

This pull request is ready to review when

  • Automated tests are updated (and all tests are passing)
  • Pull request has been labeled, if applicable with feature, content, bug, tests, refactor
  • Associated OpenAPI documentation has been updated
  • The experience passes a basic manual accessibility audit (keyboard nav, screenreader, text scaling) OR an exemption is documented

This pull request can be merged when

  • Code has been reviewed by someone other than the original author
  • QA has verified the accessibility and functionality related to the change
  • Design has approved the experience
  • Product has approved the experience

@tbolt tbolt requested a review from thetif June 27, 2022 14:58
@tbolt tbolt requested a review from Sun-Mountain June 27, 2022 15:00
@cms-eapd-bot
Copy link

cms-eapd-bot commented Jun 27, 2022

This deploy was cleaned up.

@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2022

Codecov Report

Merging #4165 (4ab0ee1) into main (b56369f) will increase coverage by 0.95%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4165      +/-   ##
==========================================
+ Coverage   87.36%   88.32%   +0.95%     
==========================================
  Files         263       57     -206     
  Lines        6061     1156    -4905     
  Branches     1245        0    -1245     
==========================================
- Hits         5295     1021    -4274     
+ Misses        713      135     -578     
+ Partials       53        0      -53     
Impacted Files Coverage Δ
web/src/components/NumberField.js
web/src/util/md.js
web/src/components/DateField.js
...pages/apd/activities/state-costs/StatePersonnel.js
web/src/pages/login/Login.js
web/src/pages/apd/apdRoutesList.js
...rc/redux/actions/editActivity/nonPersonnelCosts.js
web/src/util/regulations.js
...-and-compliance/AssurancesAndComplianceReadOnly.js
...eb/src/redux/actions/editApd/previousActivities.js
... and 196 more

Impacted file tree graph

Impacted Files Coverage Δ
web/src/components/NumberField.js
web/src/util/md.js
web/src/components/DateField.js
...pages/apd/activities/state-costs/StatePersonnel.js
web/src/pages/login/Login.js
web/src/pages/apd/apdRoutesList.js
...rc/redux/actions/editActivity/nonPersonnelCosts.js
web/src/util/regulations.js
...-and-compliance/AssurancesAndComplianceReadOnly.js
...eb/src/redux/actions/editApd/previousActivities.js
... and 196 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b56369f...4ab0ee1. Read the comment docs.

Copy link
Contributor

@mirano-darren mirano-darren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Bug fixed 😄

Copy link
Contributor

@Sun-Mountain Sun-Mountain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@beparticular beparticular left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be working properly both in the page and on budget tables in the app and on export view.

@tbolt tbolt merged commit 9125394 into main Jun 29, 2022
@tbolt tbolt deleted the tbolt/4161-numberfield-bug branch June 29, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] FTE component does not allow numbers less than 0.1
7 participants