dmirano/4147-cypress-component-testing #4174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirano-darren
added
Development
|
This deploy was cleaned up. |
tbolt
approved these changes
Jul 1, 2022
| cy.contains('Private Contractor Costs').should('exist'); | ||
|
|
||
| // Getting an uncaught:exception on save: | ||
| // TypeError: Cannot destructure property 'keyPersonnel' of 'bigState.apd.data.keyStatePersonnel' as it is undefined. |
There was a problem hiding this comment.
Is there a way you can provide a keyPersonnel? Tif mentioned yesterday that the budget calculation is likely running so you may need to provide some minimum pieces of state to satisfy the budget calculation running.
There was a problem hiding this comment.
yea there is, it's possible to put it in the initial state passed. However I did try that, and ultimately got another error I couldn't get passed. We can take a deep dive into it once we start using cypress for component testing more
thetif
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4147
Description
Adds content to the ContractorResources component test. Overall component testing in Cypress is really straight forward. Would recommend moving forward with it. Would be even better if we could figure out a way for these component tests to count towards code coverage.
Significant changes or possible side effects
None, only changed the test file
Automated test cases written
ContractorResources.js
Steps to manually verify this change
This pull request is ready to review when
This pull request can be merged when