Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update node to 16.16.0 #4227

Merged
merged 7 commits into from
Jul 26, 2022
Merged

update node to 16.16.0 #4227

merged 7 commits into from
Jul 26, 2022

Conversation

thetif
Copy link
Contributor

@thetif thetif commented Jul 22, 2022

Resolves #4195

Description

Upgrades node to 16.16.0

This pull request is ready to review when

  • Pull request has been labeled, if applicable with feature, content, bug, tests, refactor

This pull request can be merged when

  • Code has been reviewed by someone other than the original author
  • QA has verified the accessibility and functionality related to the change
  • Design has approved the experience
  • Product has approved the experience

@thetif thetif requested a review from tbolt July 22, 2022 17:42
@thetif
Copy link
Contributor Author

thetif commented Jul 22, 2022

steps to update to 16.16.0 locally

nvm install 16.16.0 --reinstall-packages-from=16.15.0
nvm alias default 16.16.0
rm yarn.lock
yarn cache clean
yarn install

@mirano-darren mirano-darren self-assigned this Jul 25, 2022
@mirano-darren mirano-darren added the dependencies Pull requests that update a dependency file label Jul 25, 2022
Copy link
Contributor

@mirano-darren mirano-darren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2022

Codecov Report

Merging #4227 (0e50fe8) into main (fd1d148) will not change coverage.
The diff coverage is n/a.

❗ Current head 0e50fe8 differs from pull request most recent head 1d4e207. Consider uploading reports for the commit 1d4e207 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4227   +/-   ##
=======================================
  Coverage   86.46%   86.46%           
=======================================
  Files         206      206           
  Lines        4972     4972           
  Branches     1255     1255           
=======================================
  Hits         4299     4299           
  Misses        614      614           
  Partials       59       59           

Impacted file tree graph


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd1d148...1d4e207. Read the comment docs.

@cms-eapd-bot
Copy link

See this pull request in action: https://ec2-52-20-242-175.compute-1.amazonaws.com

@cthulhuplus cthulhuplus merged commit 7de70d9 into main Jul 26, 2022
@cthulhuplus cthulhuplus deleted the tforkner/4195-node-upgrade branch July 26, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Maintenance] Upgrade node to 16.16.0
6 participants