Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed google tag manager #4244

Merged
merged 2 commits into from
Jul 28, 2022
Merged

removed google tag manager #4244

merged 2 commits into from
Jul 28, 2022

Conversation

thetif
Copy link
Contributor

@thetif thetif commented Jul 28, 2022

Description

removed google tag manager from application

Steps to manually verify this change

  1. open the application
  2. verify that network panel doesn't show a call to analytics.js

image

This pull request is ready to review when

  • Pull request has been labeled, if applicable with feature, content, bug, tests, refactor

This pull request can be merged when

  • Code has been reviewed by someone other than the original author
  • QA has verified the functionality related to the change
  • QA has verified the accessibility using tools such as screen readers and WAVE (accessibility evaluation tool)
  • Design has approved the experience
  • Product has approved the experience

@thetif thetif added the bug needs triage, then squashing label Jul 28, 2022
@thetif thetif requested a review from tbolt July 28, 2022 17:11
@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2022

Codecov Report

Merging #4244 (4376d99) into main (08a4d2e) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4244      +/-   ##
==========================================
- Coverage   85.91%   85.89%   -0.02%     
==========================================
  Files         205      205              
  Lines        4777     4772       -5     
  Branches     1226     1225       -1     
==========================================
- Hits         4104     4099       -5     
  Misses        614      614              
  Partials       59       59              
Impacted Files Coverage Δ
web/src/containers/ApdApplication.js 90.90% <ø> (-0.27%) ⬇️
web/src/containers/Root.js 80.00% <ø> (-5.72%) ⬇️
.../pages/dashboard/state-dashboard/StateDashboard.js 70.00% <100.00%> (-5.00%) ⬇️

Impacted file tree graph

Impacted Files Coverage Δ
web/src/containers/ApdApplication.js 90.90% <ø> (-0.27%) ⬇️
web/src/containers/Root.js 80.00% <ø> (-5.72%) ⬇️
.../pages/dashboard/state-dashboard/StateDashboard.js 70.00% <100.00%> (-5.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08a4d2e...4376d99. Read the comment docs.

@cms-eapd-bot
Copy link

See this pull request in action: https://ec2-54-147-193-218.compute-1.amazonaws.com

@thetif thetif requested a review from jeromeleecms July 28, 2022 19:29
Copy link
Contributor

@jeromeleecms jeromeleecms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't see a request to analytics.js as noted in the issue notes. Looks good to go.

@thetif thetif merged commit 8c67a0c into main Jul 28, 2022
@thetif thetif deleted the tforkner/remove-old-ga branch July 28, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug needs triage, then squashing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants