Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tbolt/1741 adds dollars to costAllocation aria message #4267

Merged
merged 10 commits into from
Aug 30, 2022

Conversation

tbolt
Copy link
Contributor

@tbolt tbolt commented Aug 10, 2022

Resolves #1741

Description

Adds more context to the aria message when entering percents into Cost Allocation tables. Previously it would read the dollar amount number only, now it is updated to end with "dollars."

Significant changes or possible side effects

None

Automated test cases written

Automated test updated to reflect expected language

Steps to manually verify this change

  1. Login and view an APD that has data. Make sure there are existing costs for the cost allocation tables
  2. Turn on a screen reader
  3. Enter/update percentages and verify the aria announce message reads the number with "dollars" at the end.4.

This pull request is ready to review when

  • Automated tests are updated (and all tests are passing)
  • Pull request has been labeled, if applicable with feature, content, bug, tests, refactor
  • Associated OpenAPI documentation has been updated
  • The experience passes a basic manual accessibility audit (keyboard nav, screenreader, text scaling) OR an exemption is documented

This pull request can be merged when

  • Code has been reviewed by someone other than the original author
  • QA has verified the functionality related to the change
  • QA has verified the accesibility using tools such as screen readers and WAVE (accessibility evaluation tool)
  • Design has approved the experience
  • Product has approved the experience

@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2022

Codecov Report

Merging #4267 (d57a892) into main (16beede) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4267   +/-   ##
=======================================
  Coverage   86.37%   86.37%           
=======================================
  Files         260      260           
  Lines        5902     5902           
  Branches     1228     1228           
=======================================
  Hits         5098     5098           
  Misses        745      745           
  Partials       59       59           
Impacted Files Coverage Δ
web/src/redux/actions/aria.js 100.00% <ø> (ø)

Impacted file tree graph

Impacted Files Coverage Δ
web/src/redux/actions/aria.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16beede...d57a892. Read the comment docs.

@cms-eapd-bot
Copy link

cms-eapd-bot commented Aug 10, 2022

This deploy was cleaned up.

@tbolt tbolt requested review from Sun-Mountain and thetif August 10, 2022 17:02
@tbolt tbolt added accessibility feature PR label for release log labels Aug 10, 2022
@mirano-darren mirano-darren self-assigned this Aug 16, 2022
@mirano-darren
Copy link
Contributor

Looks good to me! Well done! Tested with NVDA Screen reader

Given When Then Result
QuarterlyFFP table On staging (not this PR) current behavior does not read "dollars" out loud when changing the percentages PASS ✅
QuarterlyFFP table On this PR current behavior does read "dollars" out loud when changing the percentages PASS ✅

@tbolt tbolt removed the request for review from Sun-Mountain August 18, 2022 14:42
@beparticular
Copy link

@mirano-darren or @tbolt
Can I get more specifics on where I'm supposed to be looking and which fields/content I should be testing? I don't think the language in the code is matching up with the UI, so I'm not sure what I'm testing.

@mirano-darren
Copy link
Contributor

@beparticular
On the Budget and FFP page, specifically the QuarterlyFFP Table, when using a screenreader and changing the percentage values, the screen reader would read the number out loud, but it would not add "dollars" after reading the number. This PR changed it to say dollars after reading out the number.

Copy link
Contributor

@jeromeleecms jeromeleecms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Sounds" good to me!

@tbolt tbolt merged commit a98ac7b into main Aug 30, 2022
@tbolt tbolt deleted the tbolt/1741-aria-announce-update branch August 30, 2022 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility feature PR label for release log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Format Cost Allocation ARIA announcement in a way that makes sense
7 participants