-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tbolt/1741 adds dollars to costAllocation aria message #4267
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4267 +/- ##
=======================================
Coverage 86.37% 86.37%
=======================================
Files 260 260
Lines 5902 5902
Branches 1228 1228
=======================================
Hits 5098 5098
Misses 745 745
Partials 59 59
Continue to review full report at Codecov.
|
This deploy was cleaned up. |
Looks good to me! Well done! Tested with NVDA Screen reader
|
@mirano-darren or @tbolt |
@beparticular |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Sounds" good to me!
Resolves #1741
Description
Adds more context to the aria message when entering percents into Cost Allocation tables. Previously it would read the dollar amount number only, now it is updated to end with "dollars."
Significant changes or possible side effects
None
Automated test cases written
Automated test updated to reflect expected language
Steps to manually verify this change
This pull request is ready to review when
This pull request can be merged when