-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nz/4209 new apd page #4335
Nz/4209 new apd page #4335
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4335 +/- ##
==========================================
- Coverage 95.04% 94.48% -0.57%
==========================================
Files 313 314 +1
Lines 6860 6978 +118
Branches 1505 1526 +21
==========================================
+ Hits 6520 6593 +73
- Misses 334 374 +40
- Partials 6 11 +5
Continue to review full report at Codecov.
|
…/4209-new-apd-page
looks great! thanks for the persistence! |
… into nz/4209-new-apd-page
… into nz/4209-new-apd-page
Looks good, approved and ready to be moved to ready for review ✅
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The functionality for the page seems fine, but doesn't match the figma design as the "autosave" information is still present at the top of the page (not even sure where it's pulling that information from...):
Can we remove before merging? I remember we had a similar issue with the admin dashboard previously.
For the scope of this ticket, this looks good! Im assuming for the ticket dealing with the APD Overview, the field name would be added to the HITECH and MMIS options and the tooltip will go away. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good
Resolves #4209
Description
We are implementing a new workflow for creating a new APD. This page will show when the "Create new" button on the APD dashboard is clicked. Refer to the design ticket and Figma for details of how it should look.
Significant changes or possible side effects
Automated test cases written
Have been moved to #4403.
Steps to manually verify this change
enableMmis flag is off
Create new
leads you to new APD pageenableMmis flag is on
Create new
leads you to new APD pageThis pull request is ready to code review when
Automated tests are updated (and all tests are passing)Moved to Write Comprehensive Tests for 4209 #4403New automated test cases are documented aboveMoved to Write Comprehensive Tests for 4209 #4403tests, refactor
screenreader, text scaling) OR an exemption is documented
This pull request is ready to test when
This pull request is ready to review when the QA has
This pull request can be merged when