Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nz/4209 new apd page #4335

Merged
merged 103 commits into from
Dec 19, 2022
Merged

Nz/4209 new apd page #4335

merged 103 commits into from
Dec 19, 2022

Conversation

Sun-Mountain
Copy link
Contributor

@Sun-Mountain Sun-Mountain commented Sep 28, 2022

Resolves #4209

Description

We are implementing a new workflow for creating a new APD. This page will show when the "Create new" button on the APD dashboard is clicked. Refer to the design ticket and Figma for details of how it should look.

Significant changes or possible side effects

  • Adding Launch Darkly to enable/disable MMIS IAPD options
  • Reworking the workflow to create an APD

Automated test cases written

Have been moved to #4403.

Steps to manually verify this change

enableMmis flag is off

  1. Clicking Create new leads you to new APD page
  2. HITECH is automatically selected and only option
  3. You can only create APD when entire form is filled out

enableMmis flag is on

  1. Clicking Create new leads you to new APD page
  2. HITECH and MMIS options are both present
  3. You can only create APD when entire form for one choice is filled out

This pull request is ready to code review when

  • Automated tests are updated (and all tests are passing) Moved to Write Comprehensive Tests for 4209 #4403
  • New automated test cases are documented above Moved to Write Comprehensive Tests for 4209 #4403
  • Pull request has been labeled, if applicable with feature, content, bug,
    tests, refactor
  • Associated OpenAPI documentation has been updated
  • The experience passes a basic manual accessibility audit (keyboard nav,
    screenreader, text scaling) OR an exemption is documented

This pull request is ready to test when

  • Code has been reviewed by someone other than the original author

This pull request is ready to review when the QA has

  • Verified the functionality related to the change
  • Verified that the change works with Narrator on Windows
  • Verified that the change works with VoiceOver on Mac
  • Verified all updated pages with the WAVE tool
  • Verified tab and keyboard navigation functionality

This pull request can be merged when

  • Design has approved the experience
  • Product has approved the experience

@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2022

Codecov Report

Merging #4335 (d71f788) into main (0c404f8) will decrease coverage by 0.56%.
The diff coverage is 97.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4335      +/-   ##
==========================================
- Coverage   95.04%   94.48%   -0.57%     
==========================================
  Files         313      314       +1     
  Lines        6860     6978     +118     
  Branches     1505     1526      +21     
==========================================
+ Hits         6520     6593      +73     
- Misses        334      374      +40     
- Partials        6       11       +5     
Impacted Files Coverage Δ
web/src/pages/mainRoutesList.js 100.00% <ø> (ø)
web/src/pages/apd/apd-overview/ApdOverview.js 94.59% <75.00%> (-5.41%) ⬇️
web/src/pages/apd/new/ApdNew.js 99.08% <99.08%> (ø)
api/db/apds.js 92.59% <100.00%> (+0.06%) ⬆️
web/src/layout/header/ApdHeader.js 93.10% <100.00%> (ø)
web/src/layout/header/Header.js 98.07% <100.00%> (+0.07%) ⬆️
web/src/pages/dashboard/state-dashboard/ApdList.js 97.29% <100.00%> (-0.21%) ⬇️
web/src/redux/actions/app/apd.js 98.98% <100.00%> (+0.01%) ⬆️
...y-state-personnel/ApdStateProfileMedicaidOffice.js 59.64% <0.00%> (-29.83%) ⬇️
...apd/activities/schedule-and-milestones/Schedule.js 74.19% <0.00%> (-19.36%) ⬇️
... and 7 more

Impacted file tree graph

Impacted Files Coverage Δ
web/src/pages/mainRoutesList.js 100.00% <ø> (ø)
web/src/pages/apd/apd-overview/ApdOverview.js 94.59% <75.00%> (-5.41%) ⬇️
web/src/pages/apd/new/ApdNew.js 99.08% <99.08%> (ø)
api/db/apds.js 92.59% <100.00%> (+0.06%) ⬆️
web/src/layout/header/ApdHeader.js 93.10% <100.00%> (ø)
web/src/layout/header/Header.js 98.07% <100.00%> (+0.07%) ⬆️
web/src/pages/dashboard/state-dashboard/ApdList.js 97.29% <100.00%> (-0.21%) ⬇️
web/src/redux/actions/app/apd.js 98.98% <100.00%> (+0.01%) ⬆️
...y-state-personnel/ApdStateProfileMedicaidOffice.js 59.64% <0.00%> (-29.83%) ⬇️
...apd/activities/schedule-and-milestones/Schedule.js 74.19% <0.00%> (-19.36%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c404f8...d71f788. Read the comment docs.

@thetif
Copy link
Contributor

thetif commented Dec 12, 2022

looks great! thanks for the persistence!

@tbolt tbolt assigned tbolt and unassigned mirano-darren Dec 15, 2022
@tbolt
Copy link
Contributor

tbolt commented Dec 15, 2022

Looks good, approved and ready to be moved to ready for review ✅

  • Tested featureFlag - Turning it off made it so HITECH is automatically selected and only option as expected ✅
  • Tested selected all FFYs and all Update Type - ✅
  • Tested not adding a APD name for HITECH and MMIS - ✅
  • Tested MMIS with all options selected - ✅
  • Tested MMIS with a mix of options selected - ✅
  • Tested HITECH with all options selected - ✅
  • Tested HITECH with mix of options selected - ✅
  • Accessibility - Tested briefly with VoiceOver, no issues noted ✅
  • Accessibility - Ran axe DevTools - No issues found ✅

@mirano-darren
Copy link
Contributor

Looks good to me also, nice work kicking off our MMIS work! 🎉
Test Cases:
Validation:

Given When Then Result
APD Type field on-blur This field is required and cannot be blank. Should have inline validation with the error message: Select an APD Type
Is this APD an Update? field on-blur This field is required and cannot be blank. Should have inline validation with the error message: Indicate whether this APD is an update.
Medicaid Business Areas field on-blur This field is required and cannot be blank. Should have inline validation with the error message: Select at least one Medicaid Business Area. 🟨
create APD page At least one field is left blank Create an APD button should be unclickable, grayed out, and have a tooltip on hover. The tooltip should have the language: All fields are required to create an APD.
Is this APD an update? field user selects "Yes this is an update" Subsection should appear asking if the update is a Annual update or an As needed update. If left blank it should have the validation error message: Select an update type.
Medicaid Business Areas field user selects "Other" as an option A textbox should appear asking the user to document the other business area. If this field is left blank, it should have the validation error message: Provide an other Medicaid Business Area(s)

When creating a new APD:

Given When Then Result
APD Dashboard user clicks the Create New button Should redirect the user to the new create APD page
Create APD page user chooses to create a HITECH APD page should not include Medicaid Business Areas
Create APD page user chooses to create an MMIS APD page should include Medicaid Business Areas
A filled out create APD page, HITECH selected user clicks the Create APD button Should redirect to the normal HITECH APD builder; APD Overview
A filled out create APD page, MMIS selected user clicks the Create APD button Should redirect to the normal HITECH APD builder; APD Overview
create APD page user clicks the Cancel button Should close the page, redirect to the APD dashboard and no APD should be added to the dashboard.
APD Type field user is choosing between HITECH or MMIS Both selections should have help text explaining each type underneath. HITECH tooltip: Health Information Technology for Economic and Clinical Health Implementation APD. MMIS tooltip: Medicaid Management Information System Implementation APD
Create new APD page MMIS IAPD feature flag is turned off MMIS IAPD should not be listed as an option in APD type
Create new APD page MMIS IAPD feature flag is turned on MMIS IAPD should be listed as an option in APD type

One small validation language issue. Still approving the PR b/c I don't want this one small issue to bottleneck this merge:
image
Medicaid Business Areas has the validation error message for the Other text box. It should be: Select at least one Medicaid Business Area.

@mirano-darren mirano-darren self-assigned this Dec 16, 2022
Copy link
Contributor

@jeromeleecms jeromeleecms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The functionality for the page seems fine, but doesn't match the figma design as the "autosave" information is still present at the top of the page (not even sure where it's pulling that information from...):

image

Can we remove before merging? I remember we had a similar issue with the admin dashboard previously.

@akuas
Copy link

akuas commented Dec 19, 2022

For the scope of this ticket, this looks good! Im assuming for the ticket dealing with the APD Overview, the field name would be added to the HITECH and MMIS options and the tooltip will go away.

Copy link

@SGilliamA1M SGilliamA1M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good

@Sun-Mountain Sun-Mountain merged commit 885fae2 into main Dec 19, 2022
@Sun-Mountain Sun-Mountain deleted the nz/4209-new-apd-page branch December 19, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature PR label for release log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dev] Create a frontend for the new Create APD page
9 participants