Tforkner/3745 api budget #4345
Merged
Tforkner/3745 api budget #4345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…all because we need the devDependencies for webpack
…; added index for common
…correctly by the code
…ile and called common build from api; added a healthcheck to docker-compose.endpoint-test; added a wait in endpointpoint.sh and unit-test.sh
|
This deploy was cleaned up. |
tbolt
approved these changes
Oct 11, 2022
api/package.json
Outdated
| @@ -27,7 +28,7 @@ | |||
| "jest": "NODE_ENV=test jest", | |||
| "tap": "NODE_ENV=test tap -J --no-browser --no-coverage --no-timeout", | |||
| "test": "NODE_ENV=test tap -J --cov --coverage-report=text --coverage-report=lcov --no-browser", | |||
| "test-endpoints": "jest --detectOpenHandles --forceExit --runInBand", | |||
| "test-endpoints": "jest -u --detectOpenHandles --forceExit --runInBand", | |||
There was a problem hiding this comment.
Leaving a note to take the -u out before merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3745
Fixes issue with test failing
This pull request is ready to code review when
This pull request is ready to test when