Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bbrooks/4007-Terraform-Validation #4348

Merged
merged 2 commits into from
Oct 13, 2022
Merged

Conversation

cthulhuplus
Copy link
Contributor

@cthulhuplus cthulhuplus commented Oct 5, 2022

Resolves #4007

Create validation tests to make sure that the Terraform code written is valid and remains valid. The following files need to be tested:
terraform/legacy/main.tf
terraform/legacy/preview/preview.tf
terraform/legacy/prod/prod.tf
terraform/legacy/public/public.tf
terraform/legacy/staging/staging.tf

Significant changes or possible side effects

Automated test cases written

Given When Then Type (jest, tap, cypress)

Steps to manually verify this change

This pull request is ready to code review when

  • Terraform validation for terraform/legacy/main.tf is successful
  • Terraform validation for terraform/legacy/preview/preview.tf is successful
  • Terraform validation for terraform/legacy/prod/prod.tf is successful
  • Terraform validation for terraform/legacy/public/public.tf is successful
  • Terraform validation for terraform/legacy/staging/staging.tf is successful
  • Validation tests are run on night cadence

This pull request is ready to test when

  • Code has been reviewed by someone other than the original author

This pull request is ready to review when the QA has

  • Verified the functionality related to the change
  • Verified that the change works with Narrator on Windows
  • Verified that the change works with VoiceOver on Mac
  • Verified all updated pages with the WAVE tool
  • Verified tab and keyboard navigation functionality

This pull request can be merged when

  • Design has approved the experience
  • Product has approved the experience

@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2022

Codecov Report

Merging #4348 (1efe96d) into main (5e5b399) will decrease coverage by 0.06%.
The diff coverage is n/a.

❗ Current head 1efe96d differs from pull request most recent head 22452f2. Consider uploading reports for the commit 22452f2 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4348      +/-   ##
==========================================
- Coverage   85.95%   85.88%   -0.07%     
==========================================
  Files         262      262              
  Lines        5993     5994       +1     
  Branches     1266     1267       +1     
==========================================
- Hits         5151     5148       -3     
- Misses        779      782       +3     
- Partials       63       64       +1     
Impacted Files Coverage Δ
...rc/pages/admin/fed-admin/DelegateStateAdminForm.js 54.54% <0.00%> (-11.37%) ⬇️
web/src/components/RichText.js 80.88% <0.00%> (ø)
web/src/pages/apd/proposed-budget/BudgetSummary.js 100.00% <0.00%> (ø)
...pd/previous-activities/ApdPreviousActivityTable.js 100.00% <0.00%> (ø)
...revious-activities/ApdPreviousActivityTableMMIS.js 91.11% <0.00%> (ø)
web/src/components/Review.js 88.57% <0.00%> (+3.27%) ⬆️

Impacted file tree graph

Impacted Files Coverage Δ
...rc/pages/admin/fed-admin/DelegateStateAdminForm.js 54.54% <0.00%> (-11.37%) ⬇️
web/src/components/RichText.js 80.88% <0.00%> (ø)
web/src/pages/apd/proposed-budget/BudgetSummary.js 100.00% <0.00%> (ø)
...pd/previous-activities/ApdPreviousActivityTable.js 100.00% <0.00%> (ø)
...revious-activities/ApdPreviousActivityTableMMIS.js 91.11% <0.00%> (ø)
web/src/components/Review.js 88.57% <0.00%> (+3.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e5b399...22452f2. Read the comment docs.

@cthulhuplus cthulhuplus mentioned this pull request Oct 5, 2022
14 tasks
@cthulhuplus cthulhuplus requested review from thetif and tbolt and removed request for thetif October 5, 2022 19:25
Copy link
Contributor

@thetif thetif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@cms-eapd-bot
Copy link

cms-eapd-bot commented Oct 13, 2022

This deploy was cleaned up.

@cthulhuplus cthulhuplus merged commit 91e4702 into main Oct 13, 2022
@cthulhuplus cthulhuplus deleted the bbrooks/4007-Terraform-Validation branch October 13, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Validation Tests for Terraform Code
5 participants