Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tbolt/4214 admin check integration #4359

Merged

Conversation

tbolt
Copy link
Contributor

@tbolt tbolt commented Oct 14, 2022

Resolves #4212

Description

Integrates backend admin check work with front end work completing the admin check feature

Significant changes or possible side effects

Updates admin check panel to use real data vs. mocked
Added new feature flag

This pull request is ready to code review when

  • Automated tests are updated (and all tests are passing)
  • New automated test cases are documented above
  • Pull request has been labeled, if applicable with feature, content, bug,
    tests, refactor
  • Associated OpenAPI documentation has been updated
  • The experience passes a basic manual accessibility audit (keyboard nav,
    screenreader, text scaling) OR an exemption is documented

This pull request is ready to test when

  • Code has been reviewed by someone other than the original author

tbolt added 30 commits September 8, 2022 15:18
@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2022

Codecov Report

Merging #4359 (d84ea6b) into tbolt/3676-admin-check-drawer (2501191) will decrease coverage by 0.79%.
The diff coverage is 83.58%.

Impacted file tree graph

@@                        Coverage Diff                        @@
##           tbolt/3676-admin-check-drawer    #4359      +/-   ##
=================================================================
- Coverage                          86.13%   85.33%   -0.80%     
=================================================================
  Files                                265      265              
  Lines                               6137     6159      +22     
  Branches                            1317     1316       -1     
=================================================================
- Hits                                5286     5256      -30     
- Misses                               787      840      +53     
+ Partials                              64       63       -1     
Impacted Files Coverage Δ
api/db/apds.js 24.65% <0.00%> (-61.83%) ⬇️
web/src/components/AdminCheckPanel.js 90.24% <ø> (-0.24%) ⬇️
...vities/activities-dashboard/ActivitiesDashboard.js 100.00% <ø> (ø)
...ies/cost-allocation/CostAllocation/CostAllocate.js 86.36% <ø> (ø)
...eb/src/pages/apd/activities/ffp/CostAllocateFFP.js 92.06% <ø> (-1.59%) ⬇️
...w/NameAndFundingSource/NameAndFundingSourceForm.js 59.25% <ø> (ø)
web/src/pages/apd/activities/overview/Overview.js 87.50% <ø> (ø)
web/src/pages/apd/activities/overview/Schedule.js 56.66% <ø> (ø)
.../apd/activities/overview/StandardsAndConditions.js 78.26% <ø> (ø)
...y-state-personnel/ApdStateProfileMedicaidOffice.js 38.59% <ø> (ø)
... and 21 more

Impacted file tree graph

Impacted Files Coverage Δ
api/db/apds.js 24.65% <0.00%> (-61.83%) ⬇️
web/src/components/AdminCheckPanel.js 90.24% <ø> (-0.24%) ⬇️
...vities/activities-dashboard/ActivitiesDashboard.js 100.00% <ø> (ø)
...ies/cost-allocation/CostAllocation/CostAllocate.js 86.36% <ø> (ø)
...eb/src/pages/apd/activities/ffp/CostAllocateFFP.js 92.06% <ø> (-1.59%) ⬇️
...w/NameAndFundingSource/NameAndFundingSourceForm.js 59.25% <ø> (ø)
web/src/pages/apd/activities/overview/Overview.js 87.50% <ø> (ø)
web/src/pages/apd/activities/overview/Schedule.js 56.66% <ø> (ø)
.../apd/activities/overview/StandardsAndConditions.js 78.26% <ø> (ø)
...y-state-personnel/ApdStateProfileMedicaidOffice.js 38.59% <ø> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2501191...d84ea6b. Read the comment docs.

@cms-eapd-bot
Copy link

cms-eapd-bot commented Oct 14, 2022

This deploy was cleaned up.

@tbolt tbolt requested review from thetif and Sun-Mountain October 17, 2022 13:03
Copy link
Contributor

@thetif thetif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! just a couple of small suggestions

@tbolt tbolt added the feature PR label for release log label Oct 19, 2022
Copy link
Contributor

@Sun-Mountain Sun-Mountain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@tbolt tbolt merged commit 85a3323 into tbolt/3676-admin-check-drawer Oct 24, 2022
@tbolt tbolt deleted the tbolt/4214-admin-check-integration branch October 24, 2022 14:12
mirano-darren added a commit that referenced this pull request Nov 14, 2022
* pulled in code from 3674 prototype

* adds admin check scaffold

* misc

* wip admin drawer

* style updates

* wip

* wip

* adds accordions, wip

* wip

* minor style updates

* remove admin check pieces from db/apd.js, move to seed

* hardcode metadata object to post response

* update tests to handle mock metadata

* revert snapshot to correct state

* updates to accordion style

* adds back panel footer

* remove joi from api to not conflict with tifs update in yarn workspace, minor style updates

* adds demo mini check experience

* remove metadata from schema

* adds back loose validation

* update snapshots, adds demo complete mode

* fix lint errors

* add my key for preview deploys

* remove metadata from seed

* adds back dev seed mocked metadata, fixes lint and test

* adds in sticky footer

* minor style updates, adds new state props to redux

* fix tests

* adds basic redux tests to admin check panel controls

* adds basic tests for admin check panel

* fix yarn lint warnings

* fix style issues

* fix broken module issue

* fix lint warning

* adds alert to Admin Check Complete for screenreaders

* toggles admin check off on apd load

* updates admin check to be default off but only show the run check button in non-prod environments

* makes layout left-aligned

* fix lint issue

* temp fix for accordion button issue

* fix lint

* wip updates to admin check

* update data object, design updates

* adds demos

* fix frontend tests and lint

* fix vulnerability

* small update

* refactors prototype code away leaving the core components needed

* adds in a complete flag to mocked data, handles styling when an item is complete

* lint fixes, test updates

* fix typo

* fix test

* updates to mocked data

* remove snapshot

* another fix attempt

* update docker-compose to fix snapshot issues

* revert docker compose changes

* fix frontend tests

* adds broken snapshot

* Tbolt/4252 backend validation (#4327)

* fix broken test

* Tbolt/4214 admin check integration (#4359)

* started admin check cypress tests

* started admin check tests

* progress on admin check tests

* more progress on help panel tests

* testing out pushing with new repo

* testing push on new repo

* progress

* added test for a complete APD

* finished up tests

* redo yarn install/build

* updated babel-loader

* redo yarn install

* added a wat for tinyMCE to load

* turned some functions into Cypress commands

Co-authored-by: Ty Bolt <tybolt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature PR label for release log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants