-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tbolt/4214 admin check integration #4359
Merged
tbolt
merged 52 commits into
tbolt/3676-admin-check-drawer
from
tbolt/4214-admin-check-integration
Oct 24, 2022
Merged
Tbolt/4214 admin check integration #4359
tbolt
merged 52 commits into
tbolt/3676-admin-check-drawer
from
tbolt/4214-admin-check-integration
Oct 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ame, update tests
… uses strings, removes faked data
…ntend to work with it, update tests
This deploy was cleaned up. |
…n apd overview and assurances and compliances to trigger on change
thetif
approved these changes
Oct 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! just a couple of small suggestions
Sun-Mountain
approved these changes
Oct 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
mirano-darren
added a commit
that referenced
this pull request
Nov 14, 2022
* pulled in code from 3674 prototype * adds admin check scaffold * misc * wip admin drawer * style updates * wip * wip * adds accordions, wip * wip * minor style updates * remove admin check pieces from db/apd.js, move to seed * hardcode metadata object to post response * update tests to handle mock metadata * revert snapshot to correct state * updates to accordion style * adds back panel footer * remove joi from api to not conflict with tifs update in yarn workspace, minor style updates * adds demo mini check experience * remove metadata from schema * adds back loose validation * update snapshots, adds demo complete mode * fix lint errors * add my key for preview deploys * remove metadata from seed * adds back dev seed mocked metadata, fixes lint and test * adds in sticky footer * minor style updates, adds new state props to redux * fix tests * adds basic redux tests to admin check panel controls * adds basic tests for admin check panel * fix yarn lint warnings * fix style issues * fix broken module issue * fix lint warning * adds alert to Admin Check Complete for screenreaders * toggles admin check off on apd load * updates admin check to be default off but only show the run check button in non-prod environments * makes layout left-aligned * fix lint issue * temp fix for accordion button issue * fix lint * wip updates to admin check * update data object, design updates * adds demos * fix frontend tests and lint * fix vulnerability * small update * refactors prototype code away leaving the core components needed * adds in a complete flag to mocked data, handles styling when an item is complete * lint fixes, test updates * fix typo * fix test * updates to mocked data * remove snapshot * another fix attempt * update docker-compose to fix snapshot issues * revert docker compose changes * fix frontend tests * adds broken snapshot * Tbolt/4252 backend validation (#4327) * fix broken test * Tbolt/4214 admin check integration (#4359) * started admin check cypress tests * started admin check tests * progress on admin check tests * more progress on help panel tests * testing out pushing with new repo * testing push on new repo * progress * added test for a complete APD * finished up tests * redo yarn install/build * updated babel-loader * redo yarn install * added a wat for tinyMCE to load * turned some functions into Cypress commands Co-authored-by: Ty Bolt <tybolt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4212
Description
Integrates backend admin check work with front end work completing the admin check feature
Significant changes or possible side effects
Updates admin check panel to use real data vs. mocked
Added new feature flag
This pull request is ready to code review when
tests, refactor
screenreader, text scaling) OR an exemption is documented
This pull request is ready to test when