Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tforkner/3745 budget migration #4364

Merged
merged 51 commits into from
Oct 17, 2022
Merged

Tforkner/3745 budget migration #4364

merged 51 commits into from
Oct 17, 2022

Conversation

thetif
Copy link
Contributor

@thetif thetif commented Oct 17, 2022

Changes to prod ci workflo

This pull request is ready to test when

  • Code has been reviewed by someone other than the original author

thetif added 30 commits September 27, 2022 12:09
@thetif
fixed lint in e2e, added yarn lint command to main, added main lint c…
1c36b00 
…ommand to husky pre-commit
@thetif
adding lint-staged
f8e924b
@thetif
oops added pre-commit back
5c0aaea
@thetif
fixed error in pre-commit
9b96c4a
@thetif
updated the package.json lint-staged
e1336f9
@thetif
updated command again
d011f31
@thetif
trying again
e8d3bd1
@thetif
trying again
d33b81a
@thetif
trying again
1f6a63d
@thetif
adding fix back to eslint
edf681a
@thetif
launchdarkly configured correctly for front and backend and added an …
a4f327c 
…action to dispatch an alert if a flag changes so reducer can listen for the change if they need to
@thetif
updated lintstagedrc and package to fix issue with prettier
2ddf656
@thetif
updated lintstagedrc and package to fix issue with prettier
0c78196
@thetif
updated root to do the listening to flag changes, removed it from wra…
ddc50a9 
…pper
@thetif
removed lint-staged
6b8a2c1
@thetif
updated the pages with validation to turn off error messages when adm…
54cceaa 
…inCheck is off
@thetif
updated tests for feature flags
e753092
@thetif
merged in main
eedc8cc
@thetif
changed test message
c9adaf6
@thetif
updated diagrams in documents; fixed issue with validation showing up…
366755a 
… in Estimated Expenditures
@thetif
pulled in latest from main:
f6e4280
@thetif
pulled in build updates from the budget branch, and updated test date…
680690f 
…s to 2023
@thetif
updates to dates and endpoint script
bba9860
@thetif
updating circle scripts for frontend tests and owasp zap scan
b9cc32e
@thetif
added resource class to owasp zap scan
deee8e9
@thetif
upgraded resource class to xlarge
f13b1c8
@thetif
rolled resource_class backed to large; removed common build from api …
b2a46df 
…seed command
@thetif
added a docker inspect command before running zap
fd09443
@thetif
checking status of api-container and printing logs at the end
b3d20f9
@thetif
updated healthcheck
cc5f988
thetif added 20 commits October 11, 2022 16:31
@thetif
added header to healthcheck
6b56237
@thetif
added LD env vars to circle
8fa29fe
@thetif
added envs
0dac2f1
@thetif
updating so it doesn't connect to LD if there is not API key
5c612c8
@thetif
cleaning up the LD environment variables, LD doesn't get loaded if th…
388c0d4 
…ere is no env
@thetif
removed LD env so it doesn't get set on tests
0693876
@thetif
cleaning up handling LD envs when they aren't set
1895f9e
@thetif
removed example LD flag usage; fixed cypress mock for LD
308217c
@thetif
fixed issue with init if LD_API_KEY isn't set
7152773
@thetif
merged with main
7dfadbf
@thetif
typo in frontend build
1a6f0de
@thetif
add LD envs to deploy scripts
17fa7cc
@thetif
added LD_API_KEY to aws.user-data.sh
1234d2a
@thetif
Merge branch 'main' of github.com:CMSgov/eAPD into tforkner/4064-laun…
adc9637 
…ch-darkly
@thetif
fixes for costAllocationNarrative error
c8ccb3f
@thetif
Merge branch 'main' of github.com:CMSgov/eAPD into tforkner/4064-laun…
a3a7d17 
…ch-darkly
@thetif
another typo
c516cf6
@thetif
pulled in main
c7d34b1
@thetif
updates to security headers
c353bbb
@thetif
updates to prod build process
078f8b7
@thetif thetif requested a review from cthulhuplus October 17, 2022 17:29
cthulhuplus
cthulhuplus approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@cthulhuplus cthulhuplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #4364 (078f8b7) into main (5f06102) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4364   +/-   ##
=======================================
  Coverage   85.97%   85.97%           
=======================================
  Files         263      263           
  Lines        6040     6040           
  Branches     1288     1288           
=======================================
  Hits         5193     5193           
  Misses        784      784           
  Partials       63       63

Impacted file tree graph

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f06102...078f8b7. Read the comment docs.

@cms-eapd-bot
Copy link

cms-eapd-bot commented Oct 17, 2022 •
edited
Loading

This deploy was cleaned up.

@thetif thetif changed the title Tforkner/4064 launch darkly Tforkner/3745 budget migration Oct 17, 2022
@thetif thetif merged commit 7eb859a into main Oct 17, 2022
@thetif thetif deleted the tforkner/4064-launch-darkly branch October 17, 2022 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cthulhuplus cthulhuplus cthulhuplus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thetif @codecov-commenter @cms-eapd-bot @cthulhuplus