Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed unneeded user data #4370

Merged
merged 4 commits into from
Oct 24, 2022
Merged

removed unneeded user data #4370

merged 4 commits into from
Oct 24, 2022

Conversation

thetif
Copy link
Contributor

@thetif thetif commented Oct 18, 2022

Resolves PIA concerns

Description

Our application was keeping a lot of user data that we weren't using that could be considered PII. We decided to remove this information to remove all possible PII.

Significant changes or possible side effects

This will affect adding State Certificates, State Admin Dashboard, and Federal Admin Dashboard.

Steps to manually verify this change

  1. Login as Federal Admin
  2. Confirm that you can view data on all of the tabs
  3. Confirm that you can add a State Certificate
  4. Logout
  5. Login as a State Admin
  6. Confirm that you can view data on all of the tabs
  7. Confirm that clicking on Approve, Revoke, Restore opens modals and doesn't contain phone numbers.
  8. Generally confirm that the only phone number in the system belongs to the Key State Personnel

This pull request is ready to code review when

  • Automated tests are updated (and all tests are passing)
  • Associated OpenAPI documentation has been updated

This pull request is ready to test when

  • Code has been reviewed by someone other than the original author

This pull request is ready to review when the QA has

  • Verified the functionality related to the change
  • Verified that the change works with Narrator on Windows
  • Verified that the change works with VoiceOver on Mac
  • Verified all updated pages with the WAVE tool
  • Verified tab and keyboard navigation functionality

This pull request can be merged when

  • Design has approved the experience
  • Product has approved the experience

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2022

Codecov Report

Merging #4370 (b9f1fb2) into main (6fb5262) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head b9f1fb2 differs from pull request most recent head 9913c50. Consider uploading reports for the commit 9913c50 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4370      +/-   ##
==========================================
+ Coverage   85.97%   85.98%   +0.01%     
==========================================
  Files         263      263              
  Lines        6040     6038       -2     
  Branches     1288     1287       -1     
==========================================
- Hits         5193     5192       -1     
+ Misses        784      783       -1     
  Partials       63       63              
Impacted Files Coverage Δ
api/db/affiliations.js 60.00% <ø> (ø)
api/db/certifications.js 63.33% <ø> (ø)
api/db/users.js 100.00% <ø> (ø)
web/src/pages/admin/ManageRoleDialog.js 84.84% <ø> (ø)
...rc/pages/admin/fed-admin/DelegateStateAdminForm.js 66.66% <ø> (+0.75%) ⬆️
...b/src/pages/admin/fed-admin/ManageAllUsersTable.js 91.11% <ø> (ø)
...src/pages/admin/fed-admin/MatchStateAdminDialog.js 79.31% <ø> (ø)
web/src/pages/admin/fed-admin/StateAdminLetters.js 49.09% <ø> (ø)
web/src/pages/admin/state-admin/ManageUserTable.js 100.00% <ø> (ø)
api/db/oktaUsers.js 93.93% <100.00%> (ø)
... and 2 more

Impacted file tree graph

Impacted Files Coverage Δ
api/db/affiliations.js 60.00% <ø> (ø)
api/db/certifications.js 63.33% <ø> (ø)
api/db/users.js 100.00% <ø> (ø)
web/src/pages/admin/ManageRoleDialog.js 84.84% <ø> (ø)
...rc/pages/admin/fed-admin/DelegateStateAdminForm.js 66.66% <ø> (+0.75%) ⬆️
...b/src/pages/admin/fed-admin/ManageAllUsersTable.js 91.11% <ø> (ø)
...src/pages/admin/fed-admin/MatchStateAdminDialog.js 79.31% <ø> (ø)
web/src/pages/admin/fed-admin/StateAdminLetters.js 49.09% <ø> (ø)
web/src/pages/admin/state-admin/ManageUserTable.js 100.00% <ø> (ø)
api/db/oktaUsers.js 93.93% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fb5262...9913c50. Read the comment docs.

@cms-eapd-bot
Copy link

cms-eapd-bot commented Oct 18, 2022

This deploy was cleaned up.

@thetif thetif requested a review from tbolt October 18, 2022 21:58
@thetif thetif marked this pull request as ready for review October 19, 2022 15:32
@@ -75,10 +75,7 @@ tap.test('GET /states/:stateId/affiliations', async endpointTest => {
role: null,
updatedBy: null,
displayName: 'Ty Bolchoz',
email: 'tbolchoz@fearless.tech',
secondEmail: null,
primaryPhone: '4438664337',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my PII!

Copy link
Contributor

@mirano-darren mirano-darren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jeromeleecms
Copy link
Contributor

@thetif @mirano-darren I can't access the state admin dashboard when logging in as the state admin (as Alaska). Not sure if that's tied to this PR, but it's working in Staging.

@thetif
Copy link
Contributor Author

thetif commented Oct 20, 2022

You have to use em@il.com, it works in staging because I manually set it up. I have a ticket to fix the seeder, but we haven't had time yet.

Copy link
Contributor

@jeromeleecms jeromeleecms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised. We are not intentionally pulling and storing PII from authentication any longer. Any information provided by APD is going to be beyond our control, but we'll may have to consider adding some disclaimers not to provide any.

@thetif thetif merged commit b1935f4 into main Oct 24, 2022
@thetif thetif deleted the tforkner/remove-unneeded-user-data branch October 24, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants