-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed unneeded user data #4370
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4370 +/- ##
==========================================
+ Coverage 85.97% 85.98% +0.01%
==========================================
Files 263 263
Lines 6040 6038 -2
Branches 1288 1287 -1
==========================================
- Hits 5193 5192 -1
+ Misses 784 783 -1
Partials 63 63
Continue to review full report at Codecov.
|
This deploy was cleaned up. |
@@ -75,10 +75,7 @@ tap.test('GET /states/:stateId/affiliations', async endpointTest => { | |||
role: null, | |||
updatedBy: null, | |||
displayName: 'Ty Bolchoz', | |||
email: 'tbolchoz@fearless.tech', | |||
secondEmail: null, | |||
primaryPhone: '4438664337', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my PII!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
@thetif @mirano-darren I can't access the state admin dashboard when logging in as the state admin (as Alaska). Not sure if that's tied to this PR, but it's working in Staging. |
You have to use em@il.com, it works in staging because I manually set it up. I have a ticket to fix the seeder, but we haven't had time yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as advertised. We are not intentionally pulling and storing PII from authentication any longer. Any information provided by APD is going to be beyond our control, but we'll may have to consider adding some disclaimers not to provide any.
Resolves PIA concerns
Description
Our application was keeping a lot of user data that we weren't using that could be considered PII. We decided to remove this information to remove all possible PII.
Significant changes or possible side effects
This will affect adding State Certificates, State Admin Dashboard, and Federal Admin Dashboard.
Steps to manually verify this change
This pull request is ready to code review when
This pull request is ready to test when
This pull request is ready to review when the QA has
This pull request can be merged when