Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bbrooks/Build-URL-Fix-20221114 #4406

Merged
merged 5 commits into from
Nov 14, 2022

Conversation

cthulhuplus
Copy link
Contributor

Resolves #

Description

Store artifacts build URL still was point to CMSgov org, this fixes that.

Significant changes or possible side effects

Automated test cases written

Given When Then Type (jest, tap, cypress)

Steps to manually verify this change

This pull request is ready to code review when

  • Automated tests are updated (and all tests are passing)
  • New automated test cases are documented above
  • Pull request has been labeled, if applicable with feature, content, bug,
    tests, refactor
  • Associated OpenAPI documentation has been updated
  • The experience passes a basic manual accessibility audit (keyboard nav,
    screenreader, text scaling) OR an exemption is documented

This pull request is ready to test when

  • Code has been reviewed by someone other than the original author

This pull request is ready to review when the QA has

  • Verified the functionality related to the change
  • Verified that the change works with Narrator on Windows
  • Verified that the change works with VoiceOver on Mac
  • Verified all updated pages with the WAVE tool
  • Verified tab and keyboard navigation functionality

This pull request can be merged when

  • Design has approved the experience
  • Product has approved the experience

@cthulhuplus cthulhuplus requested review from thetif, tbolt and mirano-darren and removed request for thetif November 14, 2022 16:22
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2022

Codecov Report

Merging #4406 (40989d6) into main (a086bf5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4406   +/-   ##
=======================================
  Coverage   85.39%   85.39%           
=======================================
  Files         265      265           
  Lines        6163     6163           
  Branches     1321     1321           
=======================================
  Hits         5263     5263           
  Misses        837      837           
  Partials       63       63           

Impacted file tree graph


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a086bf5...40989d6. Read the comment docs.

Copy link
Contributor

@mirano-darren mirano-darren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Nice job on the speedy fix! 😄

@cthulhuplus cthulhuplus merged commit 92f8b60 into main Nov 14, 2022
@cthulhuplus cthulhuplus deleted the bbrooks/4031-Update-Packer-Cleanup-20221102 branch November 14, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants