Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bbrooks/packer-fix-20221213 #4448

Merged
merged 3 commits into from
Dec 13, 2022
Merged

bbrooks/packer-fix-20221213 #4448

merged 3 commits into from
Dec 13, 2022

Conversation

cthulhuplus
Copy link
Contributor

Resolves #
Broken builds

Description

There were still lingering CentOS values from the CentOS 7 tests, this removes them and should fix permissions error reported by Tif.

Significant changes or possible side effects

Automated test cases written

Given When Then Type (jest, tap, cypress)

Steps to manually verify this change

This pull request is ready to code review when

  • Automated tests are updated (and all tests are passing)
  • New automated test cases are documented above
  • Pull request has been labeled, if applicable with feature, content, bug,
    tests, refactor
  • Associated OpenAPI documentation has been updated
  • The experience passes a basic manual accessibility audit (keyboard nav,
    screenreader, text scaling) OR an exemption is documented

This pull request is ready to test when

  • Code has been reviewed by someone other than the original author

This pull request is ready to review when the QA has

  • Verified the functionality related to the change
  • Verified that the change works with Narrator on Windows
  • Verified that the change works with VoiceOver on Mac
  • Verified all updated pages with the WAVE tool
  • Verified tab and keyboard navigation functionality

This pull request can be merged when

  • Design has approved the experience
  • Product has approved the experience

@cthulhuplus cthulhuplus changed the title bbroks/packer-fix-20221213 bbrooks/packer-fix-20221213 Dec 13, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2022

Codecov Report

Merging #4448 (f3f183c) into main (21283d7) will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4448      +/-   ##
==========================================
+ Coverage   89.85%   89.97%   +0.11%     
==========================================
  Files         305      279      -26     
  Lines        6725     6282     -443     
  Branches     1497     1340     -157     
==========================================
- Hits         6043     5652     -391     
+ Misses        605      599       -6     
+ Partials       77       31      -46     
Impacted Files Coverage Δ
web/src/layout/footer/Footer.js 50.00% <0.00%> (-50.00%) ⬇️
...ies/oms/OutcomesAndMetrics/OutcomeAndMetricForm.js 56.66% <0.00%> (-41.67%) ⬇️
.../pages/apd/key-state-personnel/ApdKeyPersonForm.js 58.06% <0.00%> (-37.64%) ⬇️
...y-state-personnel/ApdStateProfileMedicaidOffice.js 54.38% <0.00%> (-35.09%) ⬇️
web/src/redux/actions/flags.js 66.66% <0.00%> (-33.34%) ⬇️
...activities/cost-allocation/CostAllocation/index.js 66.66% <0.00%> (-33.34%) ⬇️
web/src/pages/admin/fed-admin/StateAdminLetters.js 62.72% <0.00%> (-32.73%) ⬇️
web/src/layout/header/ApdHeader.js 62.06% <0.00%> (-31.04%) ⬇️
.../pages/dashboard/state-dashboard/StateDashboard.js 70.00% <0.00%> (-30.00%) ⬇️
...w/NameAndFundingSource/NameAndFundingSourceForm.js 74.07% <0.00%> (-22.23%) ⬇️
... and 72 more

Impacted file tree graph

Impacted Files Coverage Δ
web/src/layout/footer/Footer.js 50.00% <0.00%> (-50.00%) ⬇️
...ies/oms/OutcomesAndMetrics/OutcomeAndMetricForm.js 56.66% <0.00%> (-41.67%) ⬇️
.../pages/apd/key-state-personnel/ApdKeyPersonForm.js 58.06% <0.00%> (-37.64%) ⬇️
...y-state-personnel/ApdStateProfileMedicaidOffice.js 54.38% <0.00%> (-35.09%) ⬇️
web/src/redux/actions/flags.js 66.66% <0.00%> (-33.34%) ⬇️
...activities/cost-allocation/CostAllocation/index.js 66.66% <0.00%> (-33.34%) ⬇️
web/src/pages/admin/fed-admin/StateAdminLetters.js 62.72% <0.00%> (-32.73%) ⬇️
web/src/layout/header/ApdHeader.js 62.06% <0.00%> (-31.04%) ⬇️
.../pages/dashboard/state-dashboard/StateDashboard.js 70.00% <0.00%> (-30.00%) ⬇️
...w/NameAndFundingSource/NameAndFundingSourceForm.js 74.07% <0.00%> (-22.23%) ⬇️
... and 72 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21283d7...f3f183c. Read the comment docs.

@cms-eapd-bot
Copy link

See this pull request in action: https://ec2-54-144-151-98.compute-1.amazonaws.com

@cthulhuplus cthulhuplus merged commit 33fcf94 into main Dec 13, 2022
@cthulhuplus cthulhuplus deleted the bbrooks/packer-fix-20221213 branch December 13, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants