Dmirano/4431 security planning page #4462

mirano-darren · 2022-12-29T17:52:59Z

Resolves #4431

Description

Implements the security planning page in MMIS APDs. Along with Cypress tests for this page

Significant changes or possible side effects

Automated test cases written

Given	When	Then	Type (jest, tap, cypress)
the Security Planning page	values are entered in the fields	they are saved in the ADP in mongo	cypress
that values are saved in the fields in the APD	the page opens	the saved values should display	cypress
adminCheck is on	Security and Interface Plan and/or Business Continuity and Disaster Recovery Plan are empty	the error messages should appear under the fields and in the adminCheck panel	cypress
adminCheck is on	Security and Interface Plan and Business Continuity and Disaster Recovery Plan are filled in	there should be no error messages on the page or in the adminCheck panel	cypress
adminCheck is off	the fields are valid or invalid	no error messages are displayed	cypress
adminCheck is on	Click the Security Planning hyperlink	Redirects to the Security Planning page	cypress
adminCheck is on	Security Planning page has validation errors	Validation Errors appear in the Admin Check help panel	cypress

Steps to manually verify this change

e2e tests pass in circle
Security planning page is functional and matches the Figma design
Security planning page is in sync with the Admin Check

This pull request is ready to code review when

Automated tests are updated (and all tests are passing)
New automated test cases are documented above
Pull request has been labeled, if applicable with feature, content, bug,
tests, refactor
Associated OpenAPI documentation has been updated
The experience passes a basic manual accessibility audit (keyboard nav,
screenreader, text scaling) OR an exemption is documented

This pull request is ready to test when

Code has been reviewed by someone other than the original author

This pull request is ready to review when the QA has

Verified the functionality related to the change
Verified that the change works with Narrator on Windows
Verified that the change works with VoiceOver on Mac
Verified all updated pages with the WAVE tool
Verified tab and keyboard navigation functionality

This pull request can be merged when

Design has approved the experience
Product has approved the experience

…/4209-new-apd-page

…irano/4431-security-planning-page

codecov-commenter · 2022-12-29T17:57:15Z

Codecov Report

Merging #4462 (1624455) into main (dcb0343) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4462      +/-   ##
==========================================
+ Coverage   95.10%   95.13%   +0.03%     
==========================================
  Files         314      315       +1     
  Lines        6988     7016      +28     
  Branches     1525     1532       +7     
==========================================
+ Hits         6646     6675      +29     
+ Misses        336      335       -1     
  Partials        6        6

Impacted Files	Coverage Δ
...rc/pages/apd/security-planning/SecurityPlanning.js	`100.00% <100.00%> (+25.00%)`	⬆️
web/src/redux/actions/editApd/securityPlanning.js	`100.00% <100.00%> (ø)`
web/src/redux/selectors/apd.selectors.js	`98.11% <100.00%> (+0.15%)`	⬆️

Impacted Files	Coverage Δ
...rc/pages/apd/security-planning/SecurityPlanning.js	`100.00% <100.00%> (+25.00%)`	⬆️
web/src/redux/actions/editApd/securityPlanning.js	`100.00% <100.00%> (ø)`
web/src/redux/selectors/apd.selectors.js	`98.11% <100.00%> (+0.15%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcb0343...1624455. Read the comment docs.

tbolt

Nice work. Made a few small comments, typos and such

tbolt · 2022-12-30T13:58:26Z

e2e/cypress/integration/05-mmis/01-mmis-basics.cy.js

+        'not.exist'
+      );
+
+      // TEST CONTINUE AND BACK BUTTONS, Assurances and Compliance page crashes though.


put this as a Todo: so we can search for it

tbolt · 2022-12-30T13:59:03Z

web/src/i18n/locales/en/securityPlanning.yaml

+    heading: Security and Interface Plan
+    detail: >-
+      Provide a comprehensive Security and Interface Plan for IT systems and
+      installations involed in the administration of the Medicaid Program.


involed -> involved

tbolt · 2022-12-30T13:59:28Z

web/src/i18n/locales/en/securityPlanning.yaml

+      installations involed in the administration of the Medicaid Program.
+      Briefly Describe what is in this plan. Include topics such as site and
+      facility security, security of data communications equipment, and security
+      of Personal Helth Information (PHI).


Helth -> Health

tbolt · 2022-12-30T13:59:48Z

web/src/i18n/locales/en/securityPlanning.yaml

+    heading: Business Continuity and Disaster Recovery Plan
+    detail: >-
+      Provide a comprehensive Business Continuity and Disaster Recovery Plan for
+      IT systems and installations involed in the administration of the Medicaid


involed -> involved

tbolt · 2022-12-30T14:03:18Z

web/src/pages/apd/security-planning/SecurityPlanning.js

+  const {
+    control,
+    formState: { errors },
+    setValue,


I don't think you ever use setValue

tbolt · 2022-12-30T14:03:31Z

web/src/pages/apd/security-planning/SecurityPlanning.js

+    resolver: joiResolver(securityPlanningSchema)
+  });
+
+  console.log(`schema is ${securityPlanningSchema}`);


console.log here

…y planning page, fixed lint issue

cms-eapd-bot · 2022-12-30T16:45:24Z

See this pull request in action: https://ec2-34-192-163-36.compute-1.amazonaws.com

1624455

thetif

great work!

akuas

Looks good I think we are just calling it security planning now.

SGilliamA1M

Great work, looks good!

jeromeleecms

@mirano-darren Are the nav buttons on the bottom supposed to work yet? Clicking on either puts me to a blank screen. If it's not in scope, do we have a ticket which make sure all the nav buttons are wired up?

Everything else looks great.

mirano-darren · 2023-01-05T17:37:32Z

@mirano-darren Are the nav buttons on the bottom supposed to work yet? Clicking on either puts me to a blank screen. If it's not in scope, do we have a ticket which make sure all the nav buttons are wired up?

Everything else looks great.

~~This is expected. Some pages crash to a blank white screen. This also happened with Tif's MMIS schema PR~~
Looking into it now

…irano/4431-security-planning-page

jeromeleecms

This is good to go! Nice work!

Nicole Zonnenberg added 30 commits September 21, 2022 16:02

Set up routes for new apd

73aa838

language added

d37cb09

link to forms and form views

2f886ab

progress

be71852

years progress

c5aa631

update

3582905

construct initialState to pass on

31c8339

move schema

dc32b3e

refactor

5b2e29d

delete pages

b6bff5c

progress

e2b81b4

Merge branch 'main' into nz/4209-new-apd-page

8f5cace

update form

a02d696

Merge branch 'nz/4209-new-apd-page' of github.com:CMSgov/eAPD into nz…

a1e517f

…/4209-new-apd-page

Validation for create

0c63b43

validation final

0877199

Merge branch 'main' into nz/4209-new-apd-page

b8c06e7

add flags

fea5c18

update choices

4243603

add trigger

eb8f8d7

update

c6e5938

update ApdList test

7c1c396

update tests

aec1cc7

Update trigger

c25c364

add tooltips

e64aab3

work

fef9305

send new information for apd on create

99651d0

remove tooltips

a4f4031

remove tooltip requirement

e12ae24

Update jest test

3e6319e

mirano-darren added 3 commits December 22, 2022 12:59

cypress progress

fc05267

Merge branch 'main' of https://github.com/CMS-Enterprise/eAPD into dm…

324d421

…irano/4431-security-planning-page

Merge branch 'main' of https://github.com/CMS-Enterprise/eAPD into dm…

c07efa6

…irano/4431-security-planning-page

mirano-darren added feature PR label for release log tests PR label for release log labels Dec 29, 2022

mirano-darren requested review from thetif, tbolt and Sun-Mountain December 29, 2022 17:52

tbolt approved these changes Dec 30, 2022

View reviewed changes

fixed spelling issues (thanks ty :D), Added commmand to go to securit…

d45ca06

…y planning page, fixed lint issue

mirano-darren added 2 commits December 30, 2022 13:21

fixed path

1bd3732

fixed cypress tests

c524c5c

thetif approved these changes Jan 3, 2023

View reviewed changes

mirano-darren requested review from jeromeleecms, SGilliamA1M and akuas January 4, 2023 15:50

removed a .only

6cf68d1

akuas approved these changes Jan 4, 2023

View reviewed changes

SGilliamA1M approved these changes Jan 5, 2023

View reviewed changes

addressed comments

39e25f7

tbolt approved these changes Jan 5, 2023

View reviewed changes

jeromeleecms reviewed Jan 5, 2023

View reviewed changes

mirano-darren added 2 commits January 5, 2023 13:47

kicking off new circle run

e949d22

Merge branch 'main' of https://github.com/CMS-Enterprise/eAPD into dm…

1624455

…irano/4431-security-planning-page

jeromeleecms approved these changes Jan 9, 2023

View reviewed changes

mirano-darren merged commit f97cc98 into main Jan 9, 2023

mirano-darren deleted the dmirano/4431-security-planning-page branch January 9, 2023 16:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dmirano/4431 security planning page #4462

Dmirano/4431 security planning page #4462

mirano-darren commented Dec 29, 2022

codecov-commenter commented Dec 29, 2022 •

edited

Loading

tbolt left a comment

tbolt Dec 30, 2022

tbolt Dec 30, 2022

tbolt Dec 30, 2022

tbolt Dec 30, 2022

tbolt Dec 30, 2022

tbolt Dec 30, 2022

cms-eapd-bot commented Dec 30, 2022 •

edited

Loading

thetif left a comment

akuas left a comment

SGilliamA1M left a comment •

edited

Loading

jeromeleecms left a comment

mirano-darren commented Jan 5, 2023 •

edited

Loading

jeromeleecms left a comment

Dmirano/4431 security planning page #4462

Dmirano/4431 security planning page #4462

Conversation

mirano-darren commented Dec 29, 2022

Description

Significant changes or possible side effects

Automated test cases written

Steps to manually verify this change

This pull request is ready to code review when

This pull request is ready to test when

This pull request is ready to review when the QA has

This pull request can be merged when

codecov-commenter commented Dec 29, 2022 • edited Loading

Codecov Report

tbolt left a comment

Choose a reason for hiding this comment

tbolt Dec 30, 2022

Choose a reason for hiding this comment

tbolt Dec 30, 2022

Choose a reason for hiding this comment

tbolt Dec 30, 2022

Choose a reason for hiding this comment

tbolt Dec 30, 2022

Choose a reason for hiding this comment

tbolt Dec 30, 2022

Choose a reason for hiding this comment

tbolt Dec 30, 2022

Choose a reason for hiding this comment

cms-eapd-bot commented Dec 30, 2022 • edited Loading

thetif left a comment

Choose a reason for hiding this comment

akuas left a comment

Choose a reason for hiding this comment

SGilliamA1M left a comment • edited Loading

Choose a reason for hiding this comment

jeromeleecms left a comment

Choose a reason for hiding this comment

mirano-darren commented Jan 5, 2023 • edited Loading

jeromeleecms left a comment

Choose a reason for hiding this comment

codecov-commenter commented Dec 29, 2022 •

edited

Loading

cms-eapd-bot commented Dec 30, 2022 •

edited

Loading

SGilliamA1M left a comment •

edited

Loading

mirano-darren commented Jan 5, 2023 •

edited

Loading