Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NZ/4419 remove validation flag #4464

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Conversation

Sun-Mountain
Copy link
Contributor

@Sun-Mountain Sun-Mountain commented Jan 4, 2023

Resolves #4419

Description

We no longer need the validation Launch Darkly flag. Let's use this opportunity during dev sync to practice removing LD flags from our codebase.

Significant changes or possible side effects

Automated test cases written

Given When Then Type (jest, tap, cypress)
Validation LD flag is removed does not interrupt the application N/A

Steps to manually verify this change

  1. validation flag has been removed
  2. Anything related to validation still works as normal

This pull request is ready to code review when

  • Automated tests are updated (and all tests are passing)
  • New automated test cases are documented above
  • Pull request has been labeled, if applicable with feature, content, bug,
    tests, refactor
  • Associated OpenAPI documentation has been updated
  • The experience passes a basic manual accessibility audit (keyboard nav,
    screenreader, text scaling) OR an exemption is documented

This pull request is ready to test when

  • Code has been reviewed by someone other than the original author

This pull request is ready to review when the QA has

  • Verified the functionality related to the change
  • Verified that the change works with Narrator on Windows
  • Verified that the change works with VoiceOver on Mac
  • Verified all updated pages with the WAVE tool
  • Verified tab and keyboard navigation functionality

This pull request can be merged when

  • Design has approved the experience
  • Product has approved the experience

@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2023

Codecov Report

Merging #4464 (99a07d6) into main (82959f5) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4464      +/-   ##
==========================================
- Coverage   95.13%   95.10%   -0.04%     
==========================================
  Files         314      314              
  Lines        6992     6988       -4     
  Branches     1526     1525       -1     
==========================================
- Hits         6652     6646       -6     
- Misses        334      336       +2     
  Partials        6        6              
Impacted Files Coverage Δ
web/src/containers/Root.js 100.00% <ø> (ø)
web/src/redux/actions/flags.js 0.00% <0.00%> (-100.00%) ⬇️

Impacted file tree graph

Impacted Files Coverage Δ
web/src/containers/Root.js 100.00% <ø> (ø)
web/src/redux/actions/flags.js 0.00% <0.00%> (-100.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82959f5...99a07d6. Read the comment docs.

@cms-eapd-bot
Copy link

See this pull request in action: https://ec2-18-206-78-121.compute-1.amazonaws.com

@Sun-Mountain Sun-Mountain marked this pull request as ready for review January 4, 2023 14:19
Copy link
Contributor

@amyd11 amyd11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this removes the validation flag ✅

Copy link
Contributor

@tbolt tbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'm surprised this is the only location it's used but I can't find any other references to it. 👍

Copy link
Contributor

@thetif thetif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, I did a quick search, looks like this was the only place

@Sun-Mountain Sun-Mountain merged commit dcb0343 into main Jan 5, 2023
@Sun-Mountain Sun-Mountain deleted the nz/4419-remove-validation-flag branch January 5, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dev] Remove validation LD flag
6 participants