-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NZ/4419 remove validation flag #4464
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4464 +/- ##
==========================================
- Coverage 95.13% 95.10% -0.04%
==========================================
Files 314 314
Lines 6992 6988 -4
Branches 1526 1525 -1
==========================================
- Hits 6652 6646 -6
- Misses 334 336 +2
Partials 6 6
Continue to review full report at Codecov.
|
See this pull request in action: https://ec2-18-206-78-121.compute-1.amazonaws.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this removes the validation
flag ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'm surprised this is the only location it's used but I can't find any other references to it. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, I did a quick search, looks like this was the only place
Resolves #4419
Description
We no longer need the validation Launch Darkly flag. Let's use this opportunity during dev sync to practice removing LD flags from our codebase.
Significant changes or possible side effects
Automated test cases written
Steps to manually verify this change
This pull request is ready to code review when
tests, refactor
screenreader, text scaling) OR an exemption is documented
This pull request is ready to test when
This pull request is ready to review when the QA has
This pull request can be merged when