Tforkner/4376 upgrades #4498
Merged
Tforkner/4376 upgrades #4498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sue with __dirname
…3698-remove-babel
|
See this pull request in action: https://ec2-18-233-210-18.compute-1.amazonaws.com |
…ents and QuarterlyBudgetSummary
amyd11
approved these changes
Jan 31, 2023
| @@ -57,14 +54,15 @@ const ApdNew = ({ createApd: create }) => { | |||
| asNeededUpdate: false | |||
| }; | |||
|
|
|||
| const yearOptions = [thisFFY, thisFFY + 1, thisFFY + 2].map(y => `${y}`); | |||
| const yearOptions = defaultAPDYearOptions(); | |||
mirano-darren
approved these changes
Jan 31, 2023
There was a problem hiding this comment.
LGTM! Bug ticket with create new APD page documented in #4502
tbolt
approved these changes
Feb 1, 2023
jeromeleecms
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4376
Description
Upgraded node from 16.16.0 to 16.19.0. Upgraded babel, eslint, and all of the patch updates.
This can't be tested in Preview until Bill updates the AMI.
Significant changes or possible side effects
I had to make some changes to the APD New page because the Create New APD button wasn't disabling every time it needed to.
Also the update to core-axe came with a new rule. You aren't allowed to have an empty . In the Quarterly Federal Share and Estimated Quarterly Incentive Payments tables, were using aria-hidden on the first header cell and axe was flagging that. I took off the aria-hidden and it's passing now.
This pull request is ready to code review when
tests, refactor
This pull request is ready to test when
This pull request is ready to review when the QA has
This pull request can be merged when