Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes to migration issue #4515

Merged
merged 2 commits into from
Feb 2, 2023
Merged

fixes to migration issue #4515

merged 2 commits into from
Feb 2, 2023

Conversation

thetif
Copy link
Contributor

@thetif thetif commented Feb 2, 2023

Resolves issue that Jerome and Akua found

Description

The migration to create the new HITECH and MMIS schema broke the APDs if it ran twice. I created multiple checks and failsafes to prevent this in the future

This pull request is ready to code review when

  • Pull request has been labeled, if applicable with feature, content, bug,
    tests, refactor

This pull request is ready to test when

  • Code has been reviewed by someone other than the original author

@thetif thetif added the bug needs triage, then squashing label Feb 2, 2023
@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Merging #4515 (cb9f71e) into main (1de79e3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4515   +/-   ##
=======================================
  Coverage   94.18%   94.18%           
=======================================
  Files         250      250           
  Lines        7683     7684    +1     
  Branches     1666     1667    +1     
=======================================
+ Hits         7236     7237    +1     
  Misses        428      428           
  Partials       19       19           
Impacted Files Coverage Δ
common/utils/budget.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1de79e3...cb9f71e. Read the comment docs.

@cms-eapd-bot
Copy link

See this pull request in action: https://ec2-34-192-163-36.compute-1.amazonaws.com

@thetif thetif merged commit 6481150 into main Feb 2, 2023
@thetif thetif deleted the tforkner/fix-to-staging-issue branch February 2, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug needs triage, then squashing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants