updated assurance and compliance for mmis #4519

thetif · 2023-02-03T19:36:06Z

Resolves #4473

Description

Updated the Assurance and Compliance components to handle MMIS data. Removed some old code that creates citations on the front end if they don't already exist in the APD. This isn't needed any more because all of the APDs in staging and prod have assurance and compliance. They get added when you create and new APD. And it would be extra complicated to update it to handle the new types. Also created storybook stories.

Automated test cases written

Given	When	Then	Type (jest, tap, cypress)
a MMIS APD	the Assurances and Compliance page is loaded	it renders correctly	jest
a MMIS APD	the Assurances and Compliance Read Only page is loaded	it renders correctly	jest
a user on the Assurances and Compliance page	the user sets an IV&V compliance	an action is dispatched to update the APD	jest
a user on the Assurances and Compliance page	the user sets an IV&V justification	an action is dispatched to update the APD	jest

Steps to manually verify this change

open a MMIS APD
navigate to the Assurances and Compliance page
verify that the citation match the ones from the ticket
verify that all of the citations have a url
verify that the urls are valid
select Yes
select No and a text box should open
enter text in the text box
select Yes and the text box should disappear
select No on a citation and don't enter any text in the text box
leave a citation empty
turn on Admin Check
verify that you see an error message under the empty text box
verify that you see an error message under the empty citation
verify that you see the errors in the Admin Check panel
verify that entering text and making a selection make the error message go away
verify that the error messages went away in the Admin Check panel
open a HITECH APD
navigate to the Assurances and Compliance page
verify that the citations are different than they were for the MMIS APD

This pull request is ready to code review when

Automated tests are updated (and all tests are passing)
New automated test cases are documented above
Pull request has been labeled, if applicable with feature, content, bug,
tests, refactor

This pull request is ready to test when

Code has been reviewed by someone other than the original author

This pull request is ready to review when the QA has

Verified the functionality related to the change
Verified that the change works with Narrator on Windows
Verified that the change works with VoiceOver on Mac
Verified all updated pages with the WAVE tool
Verified tab and keyboard navigation functionality

This pull request can be merged when

Design has approved the experience
Product has approved the experience

codecov · 2023-02-03T19:39:53Z

Codecov Report

Merging #4519 (df27250) into main (9361e56) will decrease coverage by 0.39%.
The diff coverage is 69.49%.

@@            Coverage Diff             @@
##             main    #4519      +/-   ##
==========================================
- Coverage   94.33%   93.94%   -0.39%     
==========================================
  Files         253      252       -1     
  Lines        7886     7977      +91     
  Branches     1686     1705      +19     
==========================================
+ Hits         7439     7494      +55     
- Misses        428      461      +33     
- Partials       19       22       +3

Impacted Files	Coverage Δ
.../cypress/helpers/mmis/activity/default-activity.js	`97.18% <ø> (-0.08%)`	⬇️
...es/apd/activities/activities-dashboard/Activity.js	`97.05% <ø> (ø)`
web/src/redux/actions/app/apd.js	`98.98% <ø> (-0.02%)`	⬇️
web/src/redux/reducers/apd.js	`97.41% <ø> (-0.07%)`	⬇️
...e/cypress/helpers/apd/assurances-and-compliance.js	`78.01% <63.95%> (-21.99%)`	⬇️
...surances-and-compliance/AssurancesAndCompliance.js	`87.67% <66.66%> (-5.67%)`	⬇️
...cypress/page-objects/assurances-compliance-page.js	`90.32% <100.00%> (+3.36%)`	⬆️
...-and-compliance/AssurancesAndComplianceReadOnly.js	`100.00% <100.00%> (ø)`
...c/redux/actions/editApd/assurancesAndCompliance.js	`100.00% <100.00%> (ø)`
web/src/redux/selectors/apd.selectors.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9361e56...df27250. Read the comment docs.

cms-eapd-bot · 2023-02-03T20:51:40Z

See this pull request in action: https://ec2-3-210-243-7.compute-1.amazonaws.com

df27250

amyd11

Everything works as expected after creating a new MMIS APD!

At first I checked the one created with seed data and either we need to update the seed data or there was just some old data in the database in this environment. It looked like 45 CFR Part 92.36 was on the list instead of the desired "45 CFR Part 75.326". Also, some of the citations are just text and not links:

45 CFR Part 92.36
42 CFR Part 433.112(b)(5)-(9)
45 CFR Part 95.617

I just had the one question about the switch statement, but everything else looks great!

amyd11 · 2023-02-08T14:48:07Z

web/src/pages/apd/assurances-and-compliance/AssurancesAndCompliance.js

@@ -98,6 +119,8 @@ const AssurancesAndCompliance = ({
        return complyingWithSecurity(index, newValue);
      case 'softwareRights':
        return complyingWithSoftwareRights(index, newValue);
+      case 'independentVV':


It looks like this case is identical to the one on line 139. Are they supposed to be the same? If so I wonder if you can combine them

they are updating the apd when the user selects yes and no and when the user adds a justification, so I don't think they can be combined easily

thetif · 2023-02-15T16:59:20Z

@amyd11 great catch on the regulations, I went back and I think I got them all cleaned up.

amyd11

Thanks for updating the seed files! Looks good ✅

mirano-darren · 2023-02-16T20:14:33Z

Looks good! 2 small changes that don't match with the Figma:

This should be 42, not 45. Link is still correct

Compliance and progress reports should be lowercase

mirano-darren · 2023-02-16T20:18:35Z

Looks good to me pending the 2 changes requested above!

Given	When	Then	Result
A MMIS APD	On the Assurances and Compliance page	Should have the following assurances listed in order: Procurement Standards (Competition / Sole Source) - SMM, Part 11 - 45 CFR Part 95.615 - 45 CFR Part 92.36 Access to Records, Reporting and Agency Attestations - 42 CFR Part 433.112(b)(5) - (9) - 45 CFR Part 95.615 - SMM Section 11267 Software & Ownership Rights... - 45 CFR Part 95.617 - 42 CFR Part 431.300 - 45 CFR Part 164 Independent Verification and Validation (IV&V) - 45 CFR Part 95.626	🟨 See above comment
A HITECH APD	On the Assurances and Compliance page	Nothing should change. Fields should be the same as before	✅
A HITECH or MMIS APD	On the Assurances and Compliance page, answering "No" to any assurance	explanation text box opens	✅
A HITECH or MMIS APD	On the Assurances and Compliance page, Admin Check is on	Should have a validation message if: - User does not select yes or no. Validation message should be "Select yes or no" - User answers "No" but explanation text is empty. Validation message should be "Provide an explanation"	✅
A HITECH or MMIS APD	On the Assurances and Compliance page, Admin check is NOT on	Validation messages should not appear	✅
A HITECH or MMIS APD	On the Assurances and Compliance page	All Hyperlinks to assurances should take the user to the correct assurance page	✅
A MMIS APD	On the Assurances and Compliance page, all filled out	Read only view should display correct values	🟨 Export view still crashes

thetif · 2023-02-21T23:23:52Z

@mirano-darren I doubled checked the list that Jerome sent me and I think the typo is in the design. The capitalization thing didn't change in this ticket. If you check staging the casing is the same, and it matches with the casing style of the other sections. If you want to see the read-only view, you can look at the storybook.

Procurement Standards (Competition / Sole Source)

Access to Records, Reporting, and Agency Attestations

45 CFR Part 433.112 (b)(5)-(9): https://www.ecfr.gov/cgi-bin/text-idx?SID=8c677ad13ab6c202c5ae1ee1c1c0b487&mc=true&node=se42.4.433_1112&rgn=div8
45 CFR Part 95.615: https://www.ecfr.gov/cgi-bin/text-idx?SID=2cfd59b6ec7c0a6adf749237ebbd1ba1&mc=true&node=se45.1.95_1615&rgn=div8
SMM Section 11267: https://www.cms.gov/Regulations-and-Guidance/Guidance/Manuals/Paper-Based-Manuals-Items/CMS021927.html

Software & Ownership

45 CFR 95.617: https://www.ecfr.gov/cgi-bin/text-idx?SID=2cfd59b6ec7c0a6adf749237ebbd1ba1&mc=true&node=se45.1.95_1617&rgn=div8
42 CFR Part 431.300: https://www.ecfr.gov/current/title-42/chapter-IV/subchapter-C/part-431/subpart-F/section-431.300
45 CFR Part 164: https://www.ecfr.gov/current/title-45/subtitle-A/subchapter-C/part-164

IV&V

45 CFR Part 95.626: https://www.ecfr.gov/current/title-45/subtitle-A/subchapter-A/part-95/subpart-F/subject-group-ECFR8ea7e78ba47a262/section-95.626

mirano-darren

Looks good to me!

SGilliamA1M

Citations have been updated successfully for MMIS. Great job!

stephanieboydcms

Thank you for the review request. Good to move forward @thetif

thetif added 4 commits February 2, 2023 17:40

added new assurance and compliance

b87739b

updating Assurance and Compliance for MMIS

a439bec

updated AssuranceAndCompliance test

e6ced45

updated AssuranceAndComplianceReadOnly test

3a17cd2

thetif added the feature PR label for release log label Feb 3, 2023

thetif requested review from tbolt, Sun-Mountain and amyd11 February 3, 2023 19:36

thetif added 3 commits February 3, 2023 14:40

fixed typo

a7d9cb5

resolve test failures

5993704

resolve test failures

567e882

amyd11 approved these changes Feb 8, 2023

View reviewed changes

tbolt approved these changes Feb 8, 2023

View reviewed changes

thetif added 4 commits February 14, 2023 09:34

pulled in latest from main

ab9e56b

added e2e tests for MMIS Assurances and Compliance

04b4615

updated linting and tests

435663d

fixed linting error

b0774b7

cleaning up typos with regulations in seeds

588e42a

thetif requested a review from amyd11 February 15, 2023 17:00

amyd11 approved these changes Feb 15, 2023

View reviewed changes

mirano-darren self-assigned this Feb 16, 2023

thetif added 2 commits February 21, 2023 13:23

Merge branch 'main' into tforkner/4473-assurances-and-compliance

7d2ca28

Merge branch 'main' into tforkner/4473-assurances-and-compliance

bdddc43

updated some failing tests

f769938

mirano-darren approved these changes Feb 22, 2023

View reviewed changes

mirano-darren requested review from jeromeleecms and SGilliamA1M February 22, 2023 14:54

SGilliamA1M approved these changes Feb 22, 2023

View reviewed changes

thetif requested a review from stephanieboydcms February 22, 2023 23:29

stephanieboydcms approved these changes Feb 23, 2023

View reviewed changes

pulled in main

df27250

thetif merged commit c46e074 into main Feb 23, 2023

thetif deleted the tforkner/4473-assurances-and-compliance branch February 23, 2023 17:56

thetif had a problem deploying to Preview February 23, 2023 17:57 — with GitHub Actions Failure

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

updated assurance and compliance for mmis #4519

updated assurance and compliance for mmis #4519

thetif commented Feb 3, 2023 •

edited

Loading

codecov bot commented Feb 3, 2023 •

edited

Loading

cms-eapd-bot commented Feb 3, 2023 •

edited

Loading

amyd11 left a comment

amyd11 Feb 8, 2023

thetif Feb 15, 2023

thetif commented Feb 15, 2023

amyd11 left a comment

mirano-darren commented Feb 16, 2023

mirano-darren commented Feb 16, 2023

thetif commented Feb 21, 2023 •

edited

Loading

mirano-darren left a comment

SGilliamA1M left a comment

stephanieboydcms left a comment

updated assurance and compliance for mmis #4519

updated assurance and compliance for mmis #4519

Conversation

thetif commented Feb 3, 2023 • edited Loading

Description

Automated test cases written

Steps to manually verify this change

This pull request is ready to code review when

This pull request is ready to test when

This pull request is ready to review when the QA has

This pull request can be merged when

codecov bot commented Feb 3, 2023 • edited Loading

Codecov Report

cms-eapd-bot commented Feb 3, 2023 • edited Loading

amyd11 left a comment

Choose a reason for hiding this comment

amyd11 Feb 8, 2023

Choose a reason for hiding this comment

thetif Feb 15, 2023

Choose a reason for hiding this comment

thetif commented Feb 15, 2023

amyd11 left a comment

Choose a reason for hiding this comment

mirano-darren commented Feb 16, 2023

mirano-darren commented Feb 16, 2023

thetif commented Feb 21, 2023 • edited Loading

mirano-darren left a comment

Choose a reason for hiding this comment

SGilliamA1M left a comment

Choose a reason for hiding this comment

stephanieboydcms left a comment

Choose a reason for hiding this comment

thetif commented Feb 3, 2023 •

edited

Loading

codecov bot commented Feb 3, 2023 •

edited

Loading

cms-eapd-bot commented Feb 3, 2023 •

edited

Loading

thetif commented Feb 21, 2023 •

edited

Loading