-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NZ/4514 - APD name should be required in the new APD form #4534
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4534 +/- ##
=======================================
Coverage 94.33% 94.33%
=======================================
Files 253 253
Lines 7885 7885
Branches 1686 1686
=======================================
Hits 7438 7438
Misses 428 428
Partials 19 19
Continue to review full report at Codecov.
|
See this pull request in action: https://ec2-18-206-77-240.compute-1.amazonaws.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Well done 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as advertised!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look great!
Resolves #4514
Description
The new APD form should require the APD name have a value
Automated test cases written
Steps to manually verify this change
This pull request is ready to code review when
tests, refactor
screenreader, text scaling) OR an exemption is documented
This pull request is ready to test when
This pull request is ready to review when the QA has
This pull request can be merged when