updated Activity Overview read-only for MMIS #4582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ack to me about how to display Fed-State split
Codecov Report
@@ Coverage Diff @@
## main #4582 +/- ##
=======================================
Coverage 94.24% 94.25%
=======================================
Files 263 264 +1
Lines 8413 8453 +40
Branches 1787 1808 +21
=======================================
+ Hits 7929 7967 +38
- Misses 462 464 +2
Partials 22 22
Continue to review full report at Codecov.
|
|
See this pull request in action: https://ec2-34-232-189-82.compute-1.amazonaws.com |
tbolt
approved these changes
Mar 2, 2023
amyd11
approved these changes
Mar 2, 2023
Comment on lines
+1
to
+13
| /** | ||
| * Update the existing database to match the new model | ||
| * @param { import("knex").Knex } knex | ||
| * @returns { Promise<void> } | ||
| */ | ||
| export const up = async () => {}; | ||
|
|
||
| /** | ||
| * Make any changes that UNDO the up function side effects here (if possible) | ||
| * @param { import("knex").Knex } knex | ||
| * @returns { Promise<void> } | ||
| */ | ||
| export const down = async () => {}; |
There was a problem hiding this comment.
Thanks for throwing this in here
| @@ -11,7 +11,8 @@ export const FUNDING_CATEGORY_TYPE = { | |||
|
|
|||
| export const FUNDING_CATEGORY_LABEL_MAPPING = { | |||
| DDI: 'Design, Development, and Installation (DDI)', | |||
| MANDO: 'Maintenance & Operations (M&O)' | |||
| MANDO: 'Maintenance & Operations (M&O)', | |||
| MO: 'Maintenance & Operations (M&O)' | |||
|
Looks good to me! I approved the changes in the PR
|
mirano-darren
approved these changes
Mar 6, 2023
jeromeleecms
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4553
Description
Updated the Activity read-only component. Pulled out the code for the Activity Overview into it's own component. Created components for HITECH Activity Overview and MMIS Activity Overview. The HITECH Activity Overview stays the same. The MMIS Activity Over was updated to match the Figma designs. Added tests and storybook for Activity Overview component.
I also added a knex template update for es6 style code.
Figma designs were updated:
https://www.figma.com/file/hJpKHKU6fz5J0Z7fisSwa2/eAPD-MMIS-2022?node-id=4717%3A20126&t=df84z13A4Rpoo6s8-1
https://www.figma.com/file/hJpKHKU6fz5J0Z7fisSwa2/eAPD-MMIS-2022?node-id=4271%3A19818&t=df84z13A4Rpoo6s8-1
Automated test cases written
Steps to manually verify this change
You will not be able to view the read-only version of MMIS in the app, but you can verify it in storybook.
This pull request is ready to code review when
tests, refactor
screenreader, text scaling) OR an exemption is documented
This pull request is ready to test when
This pull request is ready to review when the QA has
This pull request can be merged when