Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated knex to 2.4.0 #4585

Merged
merged 6 commits into from
Mar 6, 2023
Merged

updated knex to 2.4.0 #4585

merged 6 commits into from
Mar 6, 2023

Conversation

thetif
Copy link
Contributor

@thetif thetif commented Mar 2, 2023

Resolves #4549

Description

Updated knex to 2.4.0 to meet security requirements.

This pull request is ready to code review when

  • Pull request has been labeled, if applicable with feature, content, bug,
    tests, refactor

This pull request is ready to test when

  • Code has been reviewed by someone other than the original author

This pull request is ready to review when the QA has

  • Verified the functionality related to the change
  • Verified that the change works with Narrator on Windows
  • Verified that the change works with VoiceOver on Mac
  • Verified all updated pages with the WAVE tool
  • Verified tab and keyboard navigation functionality

This pull request can be merged when

  • Design has approved the experience
  • Product has approved the experience

@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Merging #4585 (70830b5) into main (bb798b6) will decrease coverage by 6.69%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4585      +/-   ##
==========================================
- Coverage   94.23%   87.54%   -6.69%     
==========================================
  Files         263      260       -3     
  Lines        8413     8207     -206     
  Branches     1787     1787              
==========================================
- Hits         7928     7185     -743     
- Misses        463      986     +523     
- Partials       22       36      +14     
Impacted Files Coverage Δ
...e/cypress/page-objects/previous-activities-page.js 17.14% <0.00%> (-82.86%) ⬇️
e2e/cypress/helpers/apd/key-state-personnel.js 25.84% <0.00%> (-74.16%) ⬇️
...e/cypress/helpers/apd/activity-schedule-summary.js 38.46% <0.00%> (-61.54%) ⬇️
e2e/cypress/helpers/apd/proposed-budget.js 47.14% <0.00%> (-52.86%) ⬇️
e2e/cypress/helpers/apd/executive-summary.js 51.56% <0.00%> (-48.44%) ⬇️
...ress/helpers/apd/results-of-previous-activities.js 53.12% <0.00%> (-46.88%) ⬇️
e2e/cypress/helpers/apd/apd-overview.js 56.89% <0.00%> (-43.11%) ⬇️
...y-state-personnel/ApdStateProfileMedicaidOffice.js 59.64% <0.00%> (-29.83%) ⬇️
...e/cypress/helpers/apd/assurances-and-compliance.js 53.90% <0.00%> (-24.12%) ⬇️
e2e/cypress/page-objects/export-page.js 41.58% <0.00%> (-23.37%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb798b6...70830b5. Read the comment docs.

@cms-eapd-bot
Copy link

cms-eapd-bot commented Mar 2, 2023

See this pull request in action: https://ec2-52-20-242-175.compute-1.amazonaws.com

70830b5

@thetif thetif requested review from tbolt, amyd11 and Sun-Mountain March 3, 2023 14:11
@thetif thetif marked this pull request as ready for review March 3, 2023 14:11
@thetif thetif added the feature PR label for release log label Mar 3, 2023
@thetif thetif removed the feature PR label for release log label Mar 3, 2023
Copy link
Contributor

@tbolt tbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I glanced at the knex changelog to see if 2.0 introduced any breaking changes that would impact us. Doesn't look like though, this was the only change:

Restore sqlite3 package #5136

@thetif thetif merged commit c219ec8 into main Mar 6, 2023
@thetif thetif deleted the tforkner/4549-update-knex branch March 6, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Maintenance] Upgrade Knex
3 participants