-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated knex to 2.4.0 #4585
updated knex to 2.4.0 #4585
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4585 +/- ##
==========================================
- Coverage 94.23% 87.54% -6.69%
==========================================
Files 263 260 -3
Lines 8413 8207 -206
Branches 1787 1787
==========================================
- Hits 7928 7185 -743
- Misses 463 986 +523
- Partials 22 36 +14
Continue to review full report at Codecov.
|
See this pull request in action: https://ec2-52-20-242-175.compute-1.amazonaws.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I glanced at the knex changelog to see if 2.0 introduced any breaking changes that would impact us. Doesn't look like though, this was the only change:
Restore sqlite3 package #5136
Resolves #4549
Description
Updated knex to 2.4.0 to meet security requirements.
This pull request is ready to code review when
tests, refactor
This pull request is ready to test when
This pull request is ready to review when the QA has
This pull request can be merged when