-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kong changes #4593
kong changes #4593
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4593 +/- ##
==========================================
- Coverage 94.27% 94.27% -0.01%
==========================================
Files 264 264
Lines 8454 8453 -1
Branches 1681 1681
==========================================
- Hits 7970 7969 -1
Misses 461 461
Partials 23 23
Continue to review full report in Codecov by Sentry.
|
See this pull request in action: https://ec2-34-192-163-36.compute-1.amazonaws.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Got all expected results
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There isn't much that I can test/sign off here. If we have 2 devs + quality sign off, I'm good with this.
Resolves #4539
Description
Updates the authentication for the endpoints. Removed the LaunchDarkly flag. Added a check for apikey. The rest of the auth is being handled through the WAF. Changed the patch endpoint to be a post, so that it was clearer.
This pull request is ready to code review when
tests, refactor
Steps to manually verify this change
apikey
and set it to any value[{ "apdId": "apd id", "newStatus": "completed" }]
in the text area[{"apdId":"apd id","success":false,"error":"APD Id is invalid"}]
This pull request is ready to test when
This pull request is ready to review when the QA has
This pull request can be merged when