4555 [Feature] Update Read-Only View for MMIS changes to Budget and FFP

[thetif]

Resolves #4555

Description

Updated Budget and FFP read-only for MMIS. Added default messages if there are no state staff/other state expenses/private contractor costs. Added tests and cleaned up linting issues.

Chromatic Link

https://www.chromatic.com/pullrequest?appId=61d5b948cf6f17003a12bf77&number=4605

Automated test cases written

Given	When	Then	Type (jest, tap, cypress)
an APD	there is no other funding	it doesn't have other funding in the list	jest
an APD	there is other funding	other funding appears in the list	jest
a HITECH APD	displaying Budget and FFP for Activity 1	Key State Personnel are listed with State Staff	jest
a MMIS APD	displaying Budget and FFP	doesn't list Key State Personnel	jest
an APD	there is no State Staff/Other State Expenses/Private Contract	it display the default message	jest

Steps to manually verify this change

1. open a HITECH APD
2. navigate to Export and Submit
3. click on Continue to review
4. scroll down to the Budget and FFP section of Activity 1
5. verify that it displays like it did before

This pull request is ready to code review when

• Automated tests are updated (and all tests are passing)
• New automated test cases are documented above
• Chromatic link added above
• Pull request has been labeled, if applicable with feature, content, bug,
  tests, refactor
• The experience passes a basic manual accessibility audit (keyboard nav,
  screenreader, text scaling) OR an exemption is documented

This pull request is ready to test when

• Code has been reviewed by someone other than the original author

This pull request is ready to review when QA has

• Verified the functionality related to the change
• Verified that the change works with Narrator on Windows
• Verified that the change works with VoiceOver on Mac
• Verified all updated pages with the WAVE tool
• Verified tab and keyboard navigation functionality

This pull request can be merged when

• Design has approved the experience
• Product has approved the experience

[codecov]

Codecov Report

Merging #4605 (2b344bb) into main (a0a75f6) will increase coverage by 10.04%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main    #4605       +/-   ##
===========================================
+ Coverage   77.89%   87.93%   +10.04%     
===========================================
  Files         270      273        +3     
  Lines        8558     8586       +28     
  Branches     1749     1760       +11     
===========================================
+ Hits         6666     7550      +884     
+ Misses       1753      998      -755     
+ Partials      139       38      -101     

Flag	Coverage Δ
api	∅ <ø> (?)
common	99.33% <ø> (ø)
web	87.30% <100.00%> (+10.59%)	⬆️

Impacted Files	Coverage Δ
...eb/src/pages/apd/activities/ffp/CostAllocateFFP.js	97.56% <ø> (+4.70%)	⬆️
...d/activities/cost-allocation/CostAllocationRows.js	100.00% <100.00%> (+12.76%)	⬆️
...es/apd/proposed-budget/SummaryActivityBreakdown.js	100.00% <100.00%> (ø)

... and 109 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0a75f6...2b344bb. Read the comment docs.

[cms-eapd-bot]

See this pull request in action: https://ec2-34-193-194-48.compute-1.amazonaws.com

2b344bb

[Sun-Mountain]

🚀

[amyd11]

Looks good!

[mirano-darren]

Looks good to me! Nice job 😄

Given	When	Then	Covered
a HITECH APD	On the export view	Budget and FFP section should be the same and not have any MMIS updates	✅
a MMIS APD	On the export view (use Chromatic if page crashes)	Budget and FFP section should match the data in the Budget and FFP page	✅
a MMIS APD	Budget and FFP data is changed (added costs/deleted costs/edited costs)	Budget and FFP section should match the changed data	🟨 Export view not available to test
a MMIS APD	Budget and FFP data is blank	Budget and FFP section should match the empty state	✅

[SGilliamA1M]

Changes look good.

[jeromeleecms]

Looks good!