-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dmirano/4571 prev activities mmis read only #4616
Dmirano/4571 prev activities mmis read only #4616
Conversation
…es component together
…irano/4570-new-prev-activities-mmis
…b.com/CMS-Enterprise/eAPD into dmirano/4571-prev-activities-mmis-read-only
…irano/4571-prev-activities-mmis-read-only
Codecov Report
@@ Coverage Diff @@
## main #4616 +/- ##
=======================================
Coverage 94.32% 94.32%
=======================================
Files 273 273
Lines 8694 8694
Branches 1746 1746
=======================================
Hits 8201 8201
Misses 469 469
Partials 24 24
Continue to review full report in Codecov by Sentry.
|
See this pull request in action: https://ec2-18-215-204-56.compute-1.amazonaws.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Smart doing most of it in the previous ticket. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…irano/4571-prev-activities-mmis-read-only
…/github.com/CMS-Enterprise/eAPD into dmirano/4571-prev-activities-mmis-read-only
…irano/4571-prev-activities-mmis-read-only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA'd and approved!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - it seems like we may have to do a final review of all the read only / export view once this is available in the system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good
…irano/4571-prev-activities-mmis-read-only
Resolves #4571
Description
Adds read only mmis changes to the results of previous activities section
Chromatic Link
https://www.chromatic.com/build?appId=61d5b948cf6f17003a12bf77&number=1218
Significant changes or possible side effects
Steps to manually verify this change
This pull request is ready to code review when
tests, refactor
screenreader, text scaling) OR an exemption is documented
This pull request is ready to test when
This pull request is ready to review when QA has
This pull request can be merged when