Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dmirano/4571 prev activities mmis read only #4616

Merged
merged 46 commits into from
Mar 23, 2023

Conversation

mirano-darren
Copy link
Contributor

@mirano-darren mirano-darren commented Mar 17, 2023

Resolves #4571

Description

Adds read only mmis changes to the results of previous activities section

Chromatic Link

https://www.chromatic.com/build?appId=61d5b948cf6f17003a12bf77&number=1218

Significant changes or possible side effects

Steps to manually verify this change

  1. Verify changes in Chromatic matches Figma designs

This pull request is ready to code review when

  • Automated tests are updated (and all tests are passing)
  • New automated test cases are documented above
  • Chromatic link added above
  • Pull request has been labeled, if applicable with feature, content, bug,
    tests, refactor
  • Associated OpenAPI documentation has been updated
  • The experience passes a basic manual accessibility audit (keyboard nav,
    screenreader, text scaling) OR an exemption is documented

This pull request is ready to test when

  • Code has been reviewed by someone other than the original author

This pull request is ready to review when QA has

  • Verified the functionality related to the change
  • Verified that the change works with Narrator on Windows
  • Verified that the change works with VoiceOver on Mac
  • Verified all updated pages with the WAVE tool
  • Verified tab and keyboard navigation functionality

This pull request can be merged when

  • Design has approved the experience
  • Product has approved the experience

@mirano-darren mirano-darren added the feature PR label for release log label Mar 17, 2023
@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #4616 (5377f9f) into main (db18926) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4616   +/-   ##
=======================================
  Coverage   94.32%   94.32%           
=======================================
  Files         273      273           
  Lines        8694     8694           
  Branches     1746     1746           
=======================================
  Hits         8201     8201           
  Misses        469      469           
  Partials       24       24           
Flag Coverage Δ
api ∅ <ø> (∅)
common 100.00% <ø> (ø)
web 94.07% <ø> (ø)
Impacted Files Coverage Δ
...evious-activities/MmisApdPreviousActivityTables.js 92.85% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db18926...5377f9f. Read the comment docs.

@cms-eapd-bot
Copy link

cms-eapd-bot commented Mar 17, 2023

See this pull request in action: https://ec2-18-215-204-56.compute-1.amazonaws.com

5377f9f

Copy link
Contributor

@thetif thetif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Smart doing most of it in the previous ticket. 😄

Copy link
Contributor

@Sun-Mountain Sun-Mountain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to test as the read only view for an MMIS APD cannot compile.

Screenshot 2023-03-20 at 12 45 00 PM

Copy link
Contributor

@Sun-Mountain Sun-Mountain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA'd and approved!

Copy link
Contributor

@jeromeleecms jeromeleecms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - it seems like we may have to do a final review of all the read only / export view once this is available in the system.

Copy link

@SGilliamA1M SGilliamA1M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good

@mirano-darren mirano-darren merged commit 6ea2a13 into main Mar 23, 2023
@mirano-darren mirano-darren deleted the dmirano/4571-prev-activities-mmis-read-only branch March 23, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature PR label for release log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Update the Results of Previous Activities Read-only component for MMIS
8 participants