-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4599 [Feature] Create Read-Only view for Analysis of Alternatives and Risk #4618
Conversation
…4598-alternatives-and-risks
…4598-alternatives-and-risks
Codecov Report
@@ Coverage Diff @@
## main #4618 +/- ##
==========================================
+ Coverage 94.31% 94.32% +0.01%
==========================================
Files 276 277 +1
Lines 8792 8808 +16
Branches 1760 1773 +13
==========================================
+ Hits 8292 8308 +16
Misses 476 476
Partials 24 24
Continue to review full report in Codecov by Sentry.
|
…4599-alternatives-and-risk-read-only
See this pull request in action: https://ec2-3-210-243-7.compute-1.amazonaws.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty straightforward- looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Given | When | Then | Covered |
---|---|---|---|
a HITECH APD | on the export view | Analysis of Alternatives and Risk section should not appear | ✅ |
a MMIS APD | on the export view (use Chromatic if the pages crashes) | Analysis of Alternatives and Risk section should match the figma | ✅ |
a MMIS APD | Analysis of Alternatives and Risk data is blank | Analysis of Alternatives and Risk should match the empty state | ✅ |
…b.com:Enterprise-CMCS/eAPD into tforkner/4599-alternatives-and-risk-read-only
…4599-alternatives-and-risk-read-only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in Chromatic!
Resolves #4599
Description
The read-only view for Analysis of Alternatives and Risks
Chromatic Link
https://www.chromatic.com/pullrequest?appId=61d5b948cf6f17003a12bf77&number=4618
Automated test cases written
Steps to manually verify this change
This pull request is ready to code review when
tests, refactor
screenreader, text scaling) OR an exemption is documented
This pull request is ready to test when
This pull request is ready to review when QA has
This pull request can be merged when