Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4599 [Feature] Create Read-Only view for Analysis of Alternatives and Risk #4618

Merged
merged 16 commits into from
Mar 27, 2023

Conversation

thetif
Copy link
Contributor

@thetif thetif commented Mar 17, 2023

Resolves #4599

Description

The read-only view for Analysis of Alternatives and Risks

Chromatic Link

https://www.chromatic.com/pullrequest?appId=61d5b948cf6f17003a12bf77&number=4618

Automated test cases written

Given When Then Type (jest, tap, cypress)
an MMIS APD there are empty values it displays "No response was provided." jest
an MMIS APD there are values it displays the value jest

Steps to manually verify this change

  1. Must verify using Chromatic

This pull request is ready to code review when

  • Automated tests are updated (and all tests are passing)
  • New automated test cases are documented above
  • Chromatic link added above
  • Pull request has been labeled, if applicable with feature, content, bug,
    tests, refactor
  • The experience passes a basic manual accessibility audit (keyboard nav,
    screenreader, text scaling) OR an exemption is documented

This pull request is ready to test when

  • Code has been reviewed by someone other than the original author

This pull request is ready to review when QA has

  • Verified the functionality related to the change
  • Verified that the change works with Narrator on Windows
  • Verified that the change works with VoiceOver on Mac
  • Verified all updated pages with the WAVE tool
  • Verified tab and keyboard navigation functionality

This pull request can be merged when

  • Design has approved the experience
  • Product has approved the experience

@thetif thetif added the feature PR label for release log label Mar 17, 2023
@thetif thetif requested review from amyd11, tbolt and Sun-Mountain March 17, 2023 17:55
@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #4618 (354e3a3) into main (aeb5d2b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4618      +/-   ##
==========================================
+ Coverage   94.31%   94.32%   +0.01%     
==========================================
  Files         276      277       +1     
  Lines        8792     8808      +16     
  Branches     1760     1773      +13     
==========================================
+ Hits         8292     8308      +16     
  Misses        476      476              
  Partials       24       24              
Flag Coverage Δ
api ∅ <ø> (∅)
common 99.33% <ø> (ø)
web 94.05% <100.00%> (+0.01%) ⬆️
Impacted Files Coverage Δ
...ctivities/activities-dashboard/ActivityReadOnly.js 98.36% <100.00%> (+0.05%) ⬆️
...rnatives-and-risks/AlternativesAndRisksReadOnly.js 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aeb5d2b...354e3a3. Read the comment docs.

@thetif thetif marked this pull request as draft March 17, 2023 18:28
@cms-eapd-bot
Copy link

cms-eapd-bot commented Mar 17, 2023

See this pull request in action: https://ec2-3-210-243-7.compute-1.amazonaws.com

354e3a3

@thetif thetif marked this pull request as ready for review March 21, 2023 18:34
@thetif thetif requested review from amyd11, Sun-Mountain and tbolt March 21, 2023 18:34
Copy link
Contributor

@amyd11 amyd11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty straightforward- looks good!

@thetif thetif changed the title Analysis of Alternatives and Risks 4599 [Feature] Create Read-Only view for Analysis of Alternatives and Risk Mar 22, 2023
@thetif thetif removed the request for review from Sun-Mountain March 22, 2023 20:35
@thetif thetif requested a review from mirano-darren March 22, 2023 20:35
Copy link
Contributor

@mirano-darren mirano-darren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Given When Then Covered
a HITECH APD on the export view Analysis of Alternatives and Risk section should not appear
a MMIS APD on the export view (use Chromatic if the pages crashes) Analysis of Alternatives and Risk section should match the figma
a MMIS APD Analysis of Alternatives and Risk data is blank Analysis of Alternatives and Risk should match the empty state

Copy link

@SGilliamA1M SGilliamA1M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@jeromeleecms jeromeleecms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in Chromatic!

@thetif thetif merged commit 971fd79 into main Mar 27, 2023
@thetif thetif deleted the tforkner/4599-alternatives-and-risk-read-only branch March 27, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature PR label for release log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Create Read-Only view for Analysis of Alternatives and Risk
8 participants