Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates the doc link permissions, adds new doc, adds new link to doc #4626

Merged
merged 4 commits into from
Mar 21, 2023

Conversation

thetif
Copy link
Contributor

@thetif thetif commented Mar 21, 2023

Description

Updated the doc route permissions so they don't need permissions. Added a route for the new doc file. Added the doc file to the local file directories. Added a link to the new doc file on the login screen.

image

Steps to manually verify this change

  1. Go to login page
  2. Confirm that you can see the new link
  3. Confirm that clicking on the How to Get Started link brings up the correct pdf
  4. Confirm that clicking on the How to Access the eAPD link brings up the correct pdf
  5. Confirm that clicking on the State Administration Authorization Form link brings up the correct pdf

This pull request is ready to code review when

  • Pull request has been labeled, if applicable with feature, content, bug,
    tests, refactor

This pull request is ready to test when

  • Code has been reviewed by someone other than the original author

This pull request is ready to review when QA has

  • Verified the functionality related to the change
  • Verified that the change works with Narrator on Windows
  • Verified that the change works with VoiceOver on Mac
  • Verified all updated pages with the WAVE tool
  • Verified tab and keyboard navigation functionality

This pull request can be merged when

  • Design has approved the experience
  • Product has approved the experience

Verified

This commit was signed with the committer’s verified signature.
snyk-bot Snyk bot
@thetif thetif added the feature PR label for release log label Mar 21, 2023
@thetif thetif requested review from tbolt, amyd11 and Sun-Mountain March 21, 2023 14:51
@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #4626 (7ab5240) into main (31886a8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4626   +/-   ##
=======================================
  Coverage   94.32%   94.32%           
=======================================
  Files         273      273           
  Lines        8694     8694           
  Branches     1746     1746           
=======================================
  Hits         8201     8201           
  Misses        469      469           
  Partials       24       24           
Flag Coverage Δ
api ∅ <ø> (∅)
common 100.00% <ø> (ø)
web 94.07% <ø> (ø)
Impacted Files Coverage Δ
web/src/pages/login/Login.js 93.93% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31886a8...7ab5240. Read the comment docs.

@@ -56,8 +56,8 @@ services:
expose:
- 8000
volumes:
- api:/app/api # This can't be ./api:/app/api in CI/CD
- common:/app/common # This can't be ./common:/app/common in CI/CD
- ./api:/app/api # This can't be ./api:/app/api in CI/CD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget about these

@cms-eapd-bot
Copy link

cms-eapd-bot commented Mar 21, 2023

See this pull request in action: https://ec2-23-21-55-55.compute-1.amazonaws.com

7ab5240

Copy link
Contributor

@amyd11 amyd11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good & works as expected!

Copy link
Contributor

@Sun-Mountain Sun-Mountain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@thetif thetif requested a review from mirano-darren March 21, 2023 17:56
Copy link
Contributor

@mirano-darren mirano-darren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Links work as expected

Copy link
Contributor

@jeromeleecms jeromeleecms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loads files correctly.

@thetif thetif merged commit b5e624a into main Mar 21, 2023
@thetif thetif deleted the tforkner/doc-fix branch March 21, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature PR label for release log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants