-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates the doc link permissions, adds new doc, adds new link to doc #4626
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4626 +/- ##
=======================================
Coverage 94.32% 94.32%
=======================================
Files 273 273
Lines 8694 8694
Branches 1746 1746
=======================================
Hits 8201 8201
Misses 469 469
Partials 24 24
Continue to review full report in Codecov by Sentry.
|
docker-compose.endpoint-tests.yml
Outdated
@@ -56,8 +56,8 @@ services: | |||
expose: | |||
- 8000 | |||
volumes: | |||
- api:/app/api # This can't be ./api:/app/api in CI/CD | |||
- common:/app/common # This can't be ./common:/app/common in CI/CD | |||
- ./api:/app/api # This can't be ./api:/app/api in CI/CD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget about these
See this pull request in action: https://ec2-23-21-55-55.compute-1.amazonaws.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good & works as expected!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Links work as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Loads files correctly.
Description
Updated the doc route permissions so they don't need permissions. Added a route for the new doc file. Added the doc file to the local file directories. Added a link to the new doc file on the login screen.
Steps to manually verify this change
This pull request is ready to code review when
tests, refactor
This pull request is ready to test when
This pull request is ready to review when QA has
This pull request can be merged when