4624 Navigating between activities using the nav menu doesn't update the Activity Name

[amyd11]

Resolves #4624

Description

This fix displays the correct activity name (on Activity Overview page) when navigating between activities. Before the fix, the previously viewed activity name was persisting in the text box under "Activity name".

Significant changes or possible side effects

• Added a useEffect function to the NameForm component which listens for changes in the "name" value and updates the field in reach hooks form when there is a change (in this case when we navigate from one activity to another)

Automated test cases written

Given	When	Then	Type (jest, tap, cypress)
At least two activities exist (which use the NameForm component)	Navigating between the two activities	The Activity name text box should display the correct Activity's name	cypress

Steps to manually verify this change

1. Navigate to an APD that has multiple activities (at least 2 for MMIS or at least 3 for HITECH)
2. Navigate between the Activity Overview page of the two activities that have an Activity name textbox
3. Ensure that the name inside the textbox correctly reflects the activity that is selected

This pull request is ready to code review when

• Automated tests are updated (and all tests are passing)
• New automated test cases are documented above
• Chromatic link added above
• Pull request has been labeled, if applicable with feature, content, bug,
  tests, refactor
• Associated OpenAPI documentation has been updated
• The experience passes a basic manual accessibility audit (keyboard nav,
  screenreader, text scaling) OR an exemption is documented

This pull request is ready to test when

• Code has been reviewed by someone other than the original author

This pull request is ready to review when QA has

• Verified the functionality related to the change
• Verified that the change works with Narrator on Windows
• Verified that the change works with VoiceOver on Mac
• Verified all updated pages with the WAVE tool
• Verified tab and keyboard navigation functionality

This pull request can be merged when

• Design has approved the experience
• Product has approved the experience

[codecov]

Codecov Report

Merging #4630 (87414e0) into main (11ca459) will increase coverage by 8.69%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4630      +/-   ##
==========================================
+ Coverage   85.62%   94.32%   +8.69%     
==========================================
  Files         274      277       +3     
  Lines        8802     8811       +9     
  Branches     1773     1773              
==========================================
+ Hits         7537     8311     +774     
+ Misses       1158      476     -682     
+ Partials      107       24      -83     

Flag	Coverage Δ
common	99.33% <ø> (ø)
web	94.05% <100.00%> (+9.16%)	⬆️

Impacted Files	Coverage Δ
web/src/pages/apd/activities/overview/NameForm.js	100.00% <100.00%> (ø)

... and 103 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11ca459...87414e0. Read the comment docs.

[cms-eapd-bot]

This deploy was cleaned up.

[mirano-darren]

Bug fixed! Well done with the cypress test too😄

[jeromeleecms]

Looks good!