[Maintenance] fixing budget migration #4644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4644 +/- ##
==========================================
- Coverage 94.32% 87.95% -6.37%
==========================================
Files 277 274 -3
Lines 8808 8603 -205
Branches 1773 1773
==========================================
- Hits 8308 7567 -741
- Misses 476 998 +522
- Partials 24 38 +14
... and 25 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
amyd11
approved these changes
Mar 28, 2023
tbolt
approved these changes
Mar 28, 2023
| { _id: apd.budget }, | ||
| { ...budget } | ||
| { ...budget, __t: BUDGET_TYPE[apdType] } |
There was a problem hiding this comment.
is this why it is/was failing?
There was a problem hiding this comment.
I think so because I think it wasn't properly setting the discrimination so it was only saving what is in the base budget
|
This deploy was cleaned up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves budget migration issue
Description
I changed up the migration so that it does HITECH and MMIS separately because it seems to be having an issue setting the correct discriminator. I also changed the discriminators in the schemas to use constants.
This pull request is ready to code review when
tests, refactor
This pull request is ready to test when