Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dmirano/4531 mmis cypress admin check #4679

Merged
merged 44 commits into from
Apr 19, 2023

Conversation

mirano-darren
Copy link
Contributor

Resolves #4531

Description

Runs basic admin check Cypress tests on MMIS apds

Automated test cases written

Given When Then Type (jest, tap, cypress)
A MMIS APD admin check is on each hyperlink on the help panel takes the user to the correct page cypress
A MMIS APD admin check is on validation error messages appear/disappear when admin check is turned on/off cypress
A MMIS APD admin check is on each page has correct admin check functionality, validation messages disappear when field is filled out and appears when field is cleared cypress

Steps to manually verify this change

  1. tests pass on circle

This pull request is ready to code review when

  • Automated tests are updated (and all tests are passing)
  • New automated test cases are documented above
  • Chromatic link added above
  • Pull request has been labeled, if applicable with feature, content, bug,
    tests, refactor
  • Associated OpenAPI documentation has been updated
  • The experience passes a basic manual accessibility audit (keyboard nav,
    screenreader, text scaling) OR an exemption is documented

This pull request is ready to test when

  • Code has been reviewed by someone other than the original author

This pull request is ready to review when QA has

  • Verified the functionality related to the change
  • Verified that the change works with Narrator on Windows
  • Verified that the change works with VoiceOver on Mac
  • Verified all updated pages with the WAVE tool
  • Verified tab and keyboard navigation functionality

This pull request can be merged when

  • Design has approved the experience
  • Product has approved the experience

@mirano-darren mirano-darren added the tests PR label for release log label Apr 17, 2023
@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #4679 (82f804e) into main (7e23491) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4679      +/-   ##
==========================================
+ Coverage   91.64%   91.76%   +0.11%     
==========================================
  Files         285      286       +1     
  Lines        9207     9290      +83     
  Branches     1884     1894      +10     
==========================================
+ Hits         8438     8525      +87     
+ Misses        740      736       -4     
  Partials       29       29              
Flag Coverage Δ
api ∅ <ø> (∅)
common 98.75% <ø> (ø)
web 91.38% <100.00%> (+0.12%) ⬆️
Impacted Files Coverage Δ
.../cypress/helpers/apd/state-priorities-and-scope.js 100.00% <100.00%> (ø)
e2e/cypress/helpers/mmis/mmis-admin-check.js 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e23491...82f804e. Read the comment docs.

@cms-eapd-bot
Copy link

cms-eapd-bot commented Apr 17, 2023

This deploy was cleaned up.

Copy link
Contributor

@thetif thetif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!


cy.findAllByText('Add Activity').click();

// TODO: Bug Ticket 4481, Uncomment code below to navigate via side panel
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this come out now?


// Fill out "Other Medicaid Business Area(s)" text box and check that error is cleared
cy.collapseAdminCheck();
// Fill out "Other Medicaid Business Area(s)" text box
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this come out?

@mirano-darren mirano-darren merged commit 261651b into main Apr 19, 2023
@mirano-darren mirano-darren deleted the dmirano/4531-mmis-cypress-admin-check branch April 19, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests PR label for release log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Testing] Add admin check Cypress test for MMIS APDs
4 participants