Remove Launchdarkly #4681
Merged
Remove Launchdarkly #4681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ience; updated the set-up-users to use the new users that were created a while ago
Codecov Report
@@ Coverage Diff @@
## main #4681 +/- ##
==========================================
- Coverage 91.78% 90.65% -1.14%
==========================================
Files 288 288
Lines 9300 9252 -48
Branches 1891 1878 -13
==========================================
- Hits 8536 8387 -149
- Misses 735 826 +91
- Partials 29 39 +10
... and 18 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
This deploy was cleaned up. |
thetif
added
the
refactor
thetif
changed the base branch from
main
to
tforkner/4056-update-okta-connection
tbolt
approved these changes
Apr 20, 2023
| @@ -94,7 +88,7 @@ const ApdApplication = ({ | |||
| <ApdPageRoutes apdId={paramApdId} /> | |||
| </div> | |||
| </main> | |||
| {adminCheckFlag === true && <AdminCheckPanel />} | |||
| <AdminCheckPanel /> | |||
amyd11
approved these changes
Apr 20, 2023
thetif
requested review from
mirano-darren
and removed request for
Sun-Mountain
mirano-darren
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves the need for LaunchDarkly
Description
Removes LaunchDarkly from the application. Turns all previously flagged code "on". Fully enables MMIS and adminCheck. Created a work around for the new code that shows or hides New Apdland. Created work around for sysadmin and just hardcoded access for the username 'sysadmin'.
Chromatic Link
https://www.chromatic.com/pullrequest?appId=61d5b948cf6f17003a12bf77&number=4681
Significant changes or possible side effects
Enabled all beta feature code.
Steps to manually verify this change
This pull request is ready to code review when
tests, refactor
This pull request is ready to test when
This pull request is ready to review when QA has
This pull request can be merged when