Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4662 [Maintenance] Add periods to all the inline validation error messages #4682

Merged
merged 24 commits into from
Apr 20, 2023

Conversation

Sun-Mountain
Copy link
Contributor

@Sun-Mountain Sun-Mountain commented Apr 18, 2023

Resolves #4662

Description

For consistency, add punctuation to the end of every error message.

Chromatic Link

https://www.chromatic.com/build?appId=61d5b948cf6f17003a12bf77&number=1484

This pull request is ready to code review when

  • Automated tests are updated (and all tests are passing)
  • Pull request has been labeled, if applicable with feature, content, bug,
    tests, refactor

This pull request is ready to test when

  • Code has been reviewed by someone other than the original author

This pull request is ready to review when QA has

  • Verified the functionality related to the change

This pull request can be merged when

  • Design has approved the experience
  • Product has approved the experience

@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #4682 (19a7c25) into main (261651b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4682   +/-   ##
=======================================
  Coverage   91.76%   91.76%           
=======================================
  Files         286      286           
  Lines        9290     9290           
  Branches     1894     1894           
=======================================
  Hits         8525     8525           
  Misses        736      736           
  Partials       29       29           
Flag Coverage Δ
api ∅ <ø> (∅)
common 98.75% <ø> (ø)
web 91.38% <100.00%> (ø)
Impacted Files Coverage Δ
e2e/cypress/helpers/mmis/mmis-admin-check.js 100.00% <ø> (ø)
...vities/cost-allocation/CostAllocateFFPQuarterly.js 100.00% <ø> (ø)
...e/cypress/helpers/apd/assurances-and-compliance.js 60.99% <100.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 261651b...19a7c25. Read the comment docs.

@Sun-Mountain Sun-Mountain requested review from tbolt, thetif and amyd11 and removed request for tbolt and thetif April 18, 2023 18:32
Nicole Zonnenberg added 2 commits April 18, 2023 15:35
…CMS-Enterprise/eAPD into nz/4662-make-validation-errs-consistent
@Sun-Mountain Sun-Mountain marked this pull request as ready for review April 18, 2023 19:56
Nicole Zonnenberg added 3 commits April 19, 2023 10:15
@cms-eapd-bot
Copy link

cms-eapd-bot commented Apr 19, 2023

This deploy was cleaned up.

Copy link
Contributor

@tbolt tbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I glanced through the files and as far as I can tell they are all using a period at the end

@Sun-Mountain Sun-Mountain merged commit 7e92d4e into main Apr 20, 2023
@Sun-Mountain Sun-Mountain deleted the nz/4662-make-validation-errs-consistent branch April 20, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Maintenance] Add periods to all the inline validation error messages
3 participants