-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4662 [Maintenance] Add periods to all the inline validation error messages #4682
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4682 +/- ##
=======================================
Coverage 91.76% 91.76%
=======================================
Files 286 286
Lines 9290 9290
Branches 1894 1894
=======================================
Hits 8525 8525
Misses 736 736
Partials 29 29
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…CMS-Enterprise/eAPD into nz/4662-make-validation-errs-consistent
…CMS-Enterprise/eAPD into nz/4662-make-validation-errs-consistent
This deploy was cleaned up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I glanced through the files and as far as I can tell they are all using a period at the end
Resolves #4662
Description
For consistency, add punctuation to the end of every error message.
Chromatic Link
https://www.chromatic.com/build?appId=61d5b948cf6f17003a12bf77&number=1484
This pull request is ready to code review when
tests, refactor
This pull request is ready to test when
This pull request is ready to review when QA has
This pull request can be merged when