(2/2) ChatListItem to ReportActionItem V2 #57819

wildan-m · 2025-03-05T06:46:35Z

Explanation of Change

Fixed Issues

$ #51296
$ #57340
$ #57344
$ #57347
$ #57352
$ #57357
$ #57363
PROPOSAL: #51296 (comment)

Tests

Pre-condition: Login to account with various chat types

Go to Search option from bottom tab.
Click on Chat type from LHP, choose Chats
Tap on search item with image, verify the image shown in the modal
Tap on search item with attachment, verify the image shown in the modal
Ensure the search results feature works the same as staging

Verify that no errors appear in the JS console

Also Verify these issues resolved:
$ #51296
$ #57340
$ #57344
$ #57347
$ #57352
$ #57357
$ #57363

Offline tests

Same as test

QA Steps

Same as test

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

… - use ReportActionItem in ChatListItem" This reverts commit 9ed2a28.

…x/51296-chat-list-item-v2

wildan-m · 2025-03-05T06:50:48Z

@luacmartins @allgandalf Regarding this issue #57343

We have this function to determine if an action deleted

src/libs/ReportActionsUtils.ts

function isDeletedAction(reportAction: OnyxInputOrEntry<ReportAction | OptimisticIOUReportAction>): boolean {
    const message = reportAction?.message ?? [];

    if (!Array.isArray(message)) {
        return message?.html === '' || !!message?.deleted;
    }

    // A legacy deleted comment has either an empty array or an object with html field with empty string as value
    const isLegacyDeletedComment = message.length === 0 || message.at(0)?.html === '';

    return isLegacyDeletedComment || !!message.at(0)?.deleted;
}

That function is being used in shouldReportActionBeVisible and will determine isLinkedActionDeleted in reportscreen

But it will return true when the onyx is not ready, do you have any suggestion to make it more accurate? The inaccurate result will show not found page for a brief moment especially when we clear onyx data / reset first

edit:

@blazejkustra I've noticed that we have shouldShow in ReportActionBase can you explain about the prop? can that prop being used for refining isDeletedAction function? something like

function isDeletedAction(reportAction: OnyxInputOrEntry<ReportAction | OptimisticIOUReportAction>): boolean {
    const message = reportAction?.message ?? [];

    if (!Array.isArray(message)) {
        return (message?.html === '' || !!message?.deleted) && !reportAction?.shouldShow;
    }

    // A legacy deleted comment has either an empty array or an object with html field with empty string as value
    const isLegacyDeletedComment = message.length === 0 || message.at(0)?.html === '';

    return (isLegacyDeletedComment || !!message.at(0)?.deleted) && !reportAction?.shouldShow;
}

blazejkustra · 2025-03-05T07:24:01Z

@blazejkustra I've noticed that we have shouldShow in ReportActionBase can you explain about the prop? can that prop being used for refining isDeletedAction function? something like

I see myself in the git blame, but it was because I created this Onyx type when we were migrating the app to Typescript. As per comment:

    /** TODO: Not enough context */
    shouldShow?: boolean;

I don't have context what this property does 😅

luacmartins · 2025-03-05T13:05:17Z

@wildan-m I think that function is fine and I'm not sure that the function itself should be aware of data being available in Onyx or not. Can we prevent calling it outside of the function if Onyx is not ready?

…x/51296-chat-list-item-v2

wildan-m · 2025-03-06T03:38:57Z

@luacmartins this property missing from report which will cause #57344

    "invoiceReceiver": {
        "accountID": 11646283,
        "type": "individual"
    },

If possible, could we align the snapshot's report/reportAction/transaction property with the live data to guarantee consistency and avoid future regressions?

wildan-m · 2025-03-06T07:38:49Z

For #57357

I think close action shouldn't be shown in the serch results, since the action will not acually visible, it's meta action like create action

So I solve it by

                if (isDeletedAction(reportAction) || isResolvedActionableWhisper(reportAction) || reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.CLOSED || isCreatedAction(reportAction)) {
                    // eslint-disable-next-line no-continue
                    continue;
                }

Please let me know if you know other invisible reportaction types

wildan-m · 2025-03-06T08:53:38Z

#57363 probably BE, I couldn't reproduce it while offline

Kapture.2025-03-06.at.15.51.23.mp4

wildan-m · 2025-03-06T08:54:46Z

Update:

WIP
#57340
#57343

BE Pending
#57344 (#57819 (comment))

BE issue
#57363 (#57819 (comment))

Fixed
#57347
#57352
#57357

luacmartins · 2025-03-06T12:58:50Z

If possible, could we align the snapshot's report/reportAction/transaction property with the live data to guarantee consistency and avoid future regressions?

I got a PR in review to fix this. The idea with the snapshot data is that we send as little as possible back for performance reasons. I don't think we should blindly add all keys to it.

luacmartins · 2025-03-06T12:59:20Z

I think close action shouldn't be shown in the serch results, since the action will not acually visible, it's meta action like create action

This seems fine.

luacmartins · 2025-03-06T13:54:18Z

I got a PR for this one too #57819 (comment)

…x/51296-chat-list-item-v2

wildan-m · 2025-03-07T08:02:46Z

Update:

WIP
#57343

BE Pending
#57344 (#57819 (comment))

BE issue
#57363 (#57819 (comment))

Fixed
#57347
#57352
#57357
#57340

wildan-m · 2025-03-07T08:05:11Z

@luacmartins @allgandalf

Regarding #57343

isLoadingInitialReportActions is being set to false earlier when open the chatListItem, so it will show Not Found / No Activity for a brief moment any suggestion to solve it?

… "n expenses"

wildan-m · 2025-03-19T07:49:59Z

Reports - Expense edit system message appears inconsistently

BE, incorrect message value

Left (before click chat item), Right (After)

luacmartins · 2025-03-19T21:49:33Z

I'll work on a fix for that tomorrow.

…x/51296-chat-list-item-v2

wildan-m · 2025-03-20T04:03:28Z

Reports - Two same error messages when app fails to delete expense

@luacmartins @allgandalf

There is another issue regarding error message in the search result. When we clicking the close button the message in the snapshot is not automatically cleared because it currently only clear live onyx.

my question is -- should we really need to show the error message in search result?

if we don't need to show the error, we can hide it when isOnSearch is true
if we should show it then clearAllRelatedReportActionErrors function should also clear corresponding error from snapshot

luacmartins · 2025-03-20T16:56:17Z

@wildan-m I think it's fine to hide it on Search. We don't currently show other errors either

if we should show it then clearAllRelatedReportActionErrors function should also clear corresponding error from snapshot

Is this not happening because of a key name mismatch between live Onyx and snapshot?

luacmartins · 2025-03-20T21:43:42Z

#57819 (comment)

I'm unable to reproduce this one. I never see the modified expense report action. @wildan-m are you able to reproduce it?

…x/51296-chat-list-item-v2

wildan-m · 2025-03-21T06:57:56Z

#57819 (comment)

I'm unable to reproduce this one. I never see the modified expense report action. @wildan-m are you able to reproduce it?

@luacmartins The change message is no longer present in the snapshot, making it non-reproducible. Was this change intentional? If that's on purpose then we can say it's resolved.

wildan-m · 2025-03-21T06:59:57Z

Is this not happening because of a key name mismatch between live Onyx and snapshot?

Unlike onyx update, I believe that onyx.merge/onyx.set does not automatically update corresponding data under the snapshot_ prefix.

luacmartins · 2025-03-21T15:40:29Z

@luacmartins The change message is no longer present in the snapshot, making it non-reproducible. Was this change intentional? If that's on purpose then we can say it's resolved.

Yea, I think we can leave those system messages out.

luacmartins · 2025-03-21T15:41:23Z

Unlike onyx update, I believe that onyx.merge/onyx.set does not automatically update corresponding data under the snapshot_ prefix.

Hmm it should. If we have a matching key in snapshot_, any new Onyx update should also update those. Anyways, I think it's fine to not show the error there

luacmartins · 2025-03-21T19:00:35Z

@wildan-m from the list of issues, it seems like only these 3 are left, right?

Reports- Whisper does not show @mention at first, "Only visible to you" placement is incorrect - BE PR merged, waiting deploy
Reports - Expense edit system message appears inconsistently - Expected
Reports - Two same error messages when app fails to delete expense - Remove error

…rror messages when app fails to delete expense

…x/51296-chat-list-item-v2

wildan-m · 2025-03-22T07:25:40Z

Unlike onyx update, I believe that onyx.merge/onyx.set does not automatically update corresponding data under the snapshot_ prefix.

Hmm it should. If we have a matching key in snapshot_, any new Onyx update should also update those. Anyways, I think it's fine to not show the error there

@luacmartins I've inspected the merge function, but couldn't find related code to update snapshot

wildan-m · 2025-03-22T08:39:22Z

from the list of issues, it seems like only these 3 are left, right?

Just resolved prettier, lint and unit test errors, If all BE completed, I think we have resolved all issues

edit:

wait, I've found new concierge task issue, seems some properties missing. Investigating....

Kapture.2025-03-22.at.15.42.44.mp4

wildan-m · 2025-03-22T09:00:31Z

wait, I've found new concierge task issue, seems some properties missing. Investigating....

This problem is caused by the absence of 'childManagerAccountID' in the snapshot.

luacmartins · 2025-03-24T15:33:39Z

@luacmartins I've inspected the merge function, but couldn't find related code to update snapshot

@wildan-m the code to update the snapshots is called here

This problem is caused by the absence of 'childManagerAccountID' in the snapshot.

Investigating

luacmartins · 2025-03-24T17:08:44Z

This problem is caused by the absence of 'childManagerAccountID' in the snapshot.

PR in review

…x/51296-chat-list-item-v2

wildan-m added 5 commits February 25, 2025 10:17

Reapply "(2/2) Add support for all reportAction types in ChatListItem…

a21ce64

… - use ReportActionItem in ChatListItem" This reverts commit 9ed2a28.

Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi…

ef4eed0

…x/51296-chat-list-item-v2

Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi…

f38492f

…x/51296-chat-list-item-v2

Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi…

50fe351

…x/51296-chat-list-item-v2

Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi…

60a590a

…x/51296-chat-list-item-v2

wildan-m mentioned this pull request Mar 5, 2025

[$500] [Search v2.2] Add support for all reportAction types in ChatListItem #51296

Open

Fill shouldShowSubscriptAvatar

e46e17a

luacmartins requested review from luacmartins and allgandalf March 5, 2025 13:02

Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi…

c1bd9ac

…x/51296-chat-list-item-v2

wildan-m added 3 commits March 6, 2025 13:10

Fix Expensify#57347, Prettier

b812e38

hide thread on isOnSearch

9d43196

Resolve Expensify#57357

a2aef3c

wildan-m added 5 commits March 7, 2025 08:57

Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi…

70dc9c0

…x/51296-chat-list-item-v2

prettier

31efb81

Resolve Expensify#57340

95eb54e

fix search focus after merge

3db7573

remove unnecessary code

db768a1

Fix: Reports - Preview of group expenses shows description instead of…

fe0e5c6

… "n expenses"

Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi…

21141f8

…x/51296-chat-list-item-v2

Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi…

7d9fa52

…x/51296-chat-list-item-v2

wildan-m added 7 commits March 22, 2025 09:50

No need to show error on search result. Resolve: Reports - Two same e…

af8075e

…rror messages when app fails to delete expense

Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi…

cc3e2b2

…x/51296-chat-list-item-v2

prettier

77b2d30

lint and prettier

d37e89e

prettier

708dc5d

Resolve unit test error

48e1e40

more unit test resolve

c4564f0

fix performace test errors

d62869e

wildan-m closed this Mar 22, 2025

wildan-m reopened this Mar 22, 2025

wildan-m added 2 commits March 25, 2025 18:08

Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi…

b05f610

…x/51296-chat-list-item-v2

resolve test issue

a34707d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(2/2) ChatListItem to ReportActionItem V2 #57819

(2/2) ChatListItem to ReportActionItem V2 #57819

wildan-m commented Mar 5, 2025 •

edited

Loading

wildan-m commented Mar 5, 2025 •

edited

Loading

blazejkustra commented Mar 5, 2025

luacmartins commented Mar 5, 2025

wildan-m commented Mar 6, 2025

wildan-m commented Mar 6, 2025 •

edited

Loading

wildan-m commented Mar 6, 2025

wildan-m commented Mar 6, 2025 •

edited

Loading

luacmartins commented Mar 6, 2025

luacmartins commented Mar 6, 2025

luacmartins commented Mar 6, 2025

wildan-m commented Mar 7, 2025

wildan-m commented Mar 7, 2025

wildan-m commented Mar 19, 2025

luacmartins commented Mar 19, 2025

wildan-m commented Mar 20, 2025

luacmartins commented Mar 20, 2025 •

edited

Loading

luacmartins commented Mar 20, 2025 •

edited

Loading

wildan-m commented Mar 21, 2025

wildan-m commented Mar 21, 2025

luacmartins commented Mar 21, 2025

luacmartins commented Mar 21, 2025 •

edited

Loading

luacmartins commented Mar 21, 2025 •

edited

Loading

wildan-m commented Mar 22, 2025

wildan-m commented Mar 22, 2025 •

edited

Loading

wildan-m commented Mar 22, 2025

luacmartins commented Mar 24, 2025

luacmartins commented Mar 24, 2025

(2/2) ChatListItem to ReportActionItem V2 #57819

Are you sure you want to change the base?

(2/2) ChatListItem to ReportActionItem V2 #57819

Conversation

wildan-m commented Mar 5, 2025 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

wildan-m commented Mar 5, 2025 • edited Loading

blazejkustra commented Mar 5, 2025

luacmartins commented Mar 5, 2025

wildan-m commented Mar 6, 2025

wildan-m commented Mar 6, 2025 • edited Loading

wildan-m commented Mar 6, 2025

wildan-m commented Mar 6, 2025 • edited Loading

luacmartins commented Mar 6, 2025

luacmartins commented Mar 6, 2025

luacmartins commented Mar 6, 2025

wildan-m commented Mar 7, 2025

wildan-m commented Mar 7, 2025

wildan-m commented Mar 19, 2025

luacmartins commented Mar 19, 2025

wildan-m commented Mar 20, 2025

luacmartins commented Mar 20, 2025 • edited Loading

luacmartins commented Mar 20, 2025 • edited Loading

wildan-m commented Mar 21, 2025

wildan-m commented Mar 21, 2025

luacmartins commented Mar 21, 2025

luacmartins commented Mar 21, 2025 • edited Loading

luacmartins commented Mar 21, 2025 • edited Loading

wildan-m commented Mar 22, 2025

wildan-m commented Mar 22, 2025 • edited Loading

wildan-m commented Mar 22, 2025

luacmartins commented Mar 24, 2025

luacmartins commented Mar 24, 2025

wildan-m commented Mar 5, 2025 •

edited

Loading

wildan-m commented Mar 5, 2025 •

edited

Loading

wildan-m commented Mar 6, 2025 •

edited

Loading

wildan-m commented Mar 6, 2025 •

edited

Loading

luacmartins commented Mar 20, 2025 •

edited

Loading

luacmartins commented Mar 20, 2025 •

edited

Loading

luacmartins commented Mar 21, 2025 •

edited

Loading

luacmartins commented Mar 21, 2025 •

edited

Loading

wildan-m commented Mar 22, 2025 •

edited

Loading