Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: When url_can_be_shared_between_users user url counts show incorrect number #135

Closed
mshannaq opened this issue Dec 30, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@mshannaq
Copy link
Member

mshannaq commented Dec 30, 2023

Describe the bug
when url_can_be_shared_between_users option is enabled then if you list users you will see incorrect url numbers for every user

To Reproduce
Steps to reproduce the behavior:

  1. enable smartyurl.url_can_be_shared_between_users on .env
  2. login as superadmin
  3. list users
  4. take a look to users URLs count.

Expected behavior
the problem exists because the system till count shared link as user links

so we should change the function that count the URLs of user to return only his links not the shared also.

even when listing the user url by admin e.g https://smartyurl.test/index.php/url/user/2 it show the shared also , and note that if you plan to change this you should consider while the user list his urls by himself.

using Smarty v0.0.0-dev.6

@mshannaq mshannaq added the bug Something isn't working label Dec 30, 2023
mshannaq added a commit that referenced this issue Jan 8, 2024
bug : fix url counts show incorrect number when url is shared #135
@mshannaq mshannaq closed this as completed Jan 8, 2024
@mshannaq mshannaq linked a pull request Jan 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant